Followers/Following list doesn't contain all items, pagination needed

[aershov24]

TASK or Feature

Request or User Story

It seems there is currently a limitation how many followers you could see on the https://dev.to/dashboard/user_followers page. Consequently there is no ability to follow people back who followed you while ago.

Definition of Done

user_followers page contains all the list of following users or has pagination to reach anyones contact to follow back.

[jessleenyc]

@benhalpern are you thinking pagination or infinite scroll for this?

[stale]

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

[michael-tharrington]

Need to reopen.

[jessleenyc]

This is approved if anyone wants to work on it.

[omenking]

@jessleenyc what was wanted here? infinite scroll or traditional pagination?

[jessleenyc]

@omenking let's go with infinite scroll!

[omenking]

So infinite scroll exists on articles/index so going to see how I can translate that over to the dashboard/followers page.

Here I see a loading articles element

    <div class="loading-articles" id="loading-articles">
      loading...
    </div>

I'm thinking this has the js required to infinite scroll

<%= render "stories/stories_list_script" %>

Yep it looks like I'm right. I can do the same here for the other page. I do wonder if @benhalpern wants inline javascript because I would think it may be preferred for this code to go into app/javascripts. My though being this code does not get minified/uglified being over here. I don't personally care which way but can align to whatever standards the project wants to achieve.

You know what. I think stories_list_script doesn't have to do with infinite scroll now that I'm reading it.

[omenking]

Doing a search for 'loading-articles I was able to locate infinite scroll functionality.

I see an insertArticles and so I guess I'll be writing an insertFollowers / insertFollowings
I'm seeing Algolia being used here which I'm seeing is used everywhere in the app. I guess Algolia is not just used for search but is also a cache for many other things

user-dashboard is being used for multiple elements from different pages but I need a distinct id for each of theses pages so changing

• user-dashboard-articles for dashboards#show
• user-dashboard-following for dashboards#following
• user-dashboard-followers for dashboards#followers

Oh, dashboard#following is not as straightforward as followers because it has multiple sub listings eg.

  <h2>Followed tags (<%= @user.following_tags_count %>)</h2>
  <h2>Followed users (<%= @user.following_users_count %>)</h2>
  <h2>Followed organizations (<%= @followed_organizations.count %>)</h2>

This is problematic here, I'll have to see what this looks like production. Maybe will need to break these up into their own pages so we can then add infinite scroll.

So see here. So a sub navigation could be added or there can be one flat nav. In either cases these need to be on their own page. So I will do that and then ask how we would like the nav to work.

Look at that we have lots of room:

Okay so biggest issue here is I don't have sufficent seed data, going to spin up a new ticket to do that now.

[eschafer]

Hi - just wanted to point out that this page has a footer, which would potentially be really difficult to get to with an infinite scroll above it.

[omenking]

This is the footer. I think this would be negligible if we couldn't access it because of the infinite scroll.

I really want this feature so I'm going get on this again this week. It's mostly done but I have to do Q&A with it.

[johncurcio]

I'd love to work on this if nobody is working anymore. @omenking are you still working on this?

[omenking]

go for it. I did finish it but was never able to have it easily tested based on the lack of seed data