Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled rubocop/lint #2130

Merged
merged 4 commits into from Mar 21, 2019
Merged

Enabled rubocop/lint #2130

merged 4 commits into from Mar 21, 2019

Conversation

venarius
Copy link

@venarius venarius commented Mar 20, 2019 •
edited

What type of PR is this? (check all applicable)

  • [ x] Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This enables the rubocop/lint

Related Tickets & Documents

#2021

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • [ x] no documentation needed

@venarius venarius changed the title WIP: Enabled rubocop/lint Enabled rubocop/lint Mar 20, 2019
@lightalloy lightalloy mentioned this pull request Mar 21, 2019
Closed
@benhalpern benhalpern merged commit 3494264 into forem:master Mar 21, 2019
@pr-triage pr-triage bot added the PR: merged bot applied label for PR's that are merged label Mar 21, 2019
@venarius venarius deleted the enable_rubocop_lint branch March 21, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes left review comments

@lightalloy lightalloy lightalloy approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@venarius @lightalloy @rhymes @benhalpern