Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Ability to search discoverable channels and send request to join #7385

Merged
merged 150 commits into from
May 11, 2020
Merged

🚀 Feature: Ability to search discoverable channels and send request to join #7385

merged 150 commits into from
May 11, 2020

Conversation

sarthology
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  1. Mod will be able to make their groups discoverable is the channel setting.

image

2. These groups then can be searched from the search option in the chat channel list.

Screen Recording 2020-04-20 at 05 46 PM

  1. One can slick and send the request to join.

Screen Recording 2020-04-20 at 05 47 PM

  1. Mod can accept and reject the request.

Screenshot 2020-04-20 at 5 48 24 PM

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

sarthology and others added 30 commits December 6, 2019 15:22
@sarthology
Merge pull request #1 from thepracticaldev/master
1c3444c 
Merge
@sarthology
Feature 🚀 : Ability to delete messages in chat channels
b440e53 
- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime
@sarthology
Minor Bug 🐞: Show message action only for current user
e6f8d29 
- User can delete or edit their own messages
@sarthology
Test cases added
e796764
@sarthology
Bug 🐞: Update message id for receiver
bb01218 
Message id was not sent to receiver by pusher
@sarthology
Refactoring🛠: Message controller refactoring
8d402cf
@sarthology
Test Cases📝 : Specs for Delete message added
a8bd27c
@sarthology
Feature 🚀 : Ability to edit messages
bb805ed
@sarthology
Test Cases📝 : Specs for Edit message added
481f0db
@sarthology
Merge pull request #2 from SkynoxTech/feature/ability_to_delete_and_e…
1b4275b 
…dit_messages

Feature/ability to delete and edit messages
@sarthology
Merge remote-tracking branch 'upstream/master'
1421c0f
@sarthology
Merge remote-tracking branch 'upstream/master'
71c6582
@sarthology
Merge remote-tracking branch 'origin/master'
a67f57c
@sarthology
Merge conflict handled
7a23050
@sarthology
Merge remote-tracking branch 'upstream/master'
e2ba1b4
@sarthology
merge conflicts handled
ef7d1f8
@sarthology
Merge branch 'master' of github.com:thepracticaldev/dev.to
b8d4599
@sarthology
Merge remote-tracking branch 'upstream/master'
8f1e9fe
@sarthology
Merge branch 'master' of github.com:thepracticaldev/dev.to
fb32bbb
@sarthology
Merge remote-tracking branch 'upstream/master'
eebd53c
@sarthology
Merge remote-tracking branch 'upstream/master'
bf4cc32
@sarthology
Merge branch 'master' of github.com:thepracticaldev/dev.to
db58ebb
@sarthology
merge handled
a031448
@sarthology
Merge branch 'master' of github.com:thepracticaldev/dev.to
a2eb94e
@Parasgr-code
added new column discoverable for public channel and changes in elast…
e3ea3ea 
…icsearch
@Parasgr-code
fix corrections
dc8f595
@Parasgr-code
changes in serializer file, added channel_discoverable
ff0bb7a
@Parasgr-code
added checkbox with discoverable policy
dc49f21
@Parasgr-code
changes in code for discoverable channels
d5bedd0
@Parasgr-code
accept and reject member invitation by mod
86e6711
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels May 4, 2020
@benhalpern
Copy link
Contributor

Hmmm I can't seem to get it to work for me locally. I'll try again tomorrow.

@sarthology
Copy link
Contributor Author

Hmmm I can't seem to get it to work for me locally. I'll try again tomorrow.

😱 Can you tell me what's exactly not working?

mstruve
mstruve reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am probably just totally blind and missing it, but where in the code do we insert a viewable_by: all record into Elasticsearch for the discoverable Chat Channels?

app/controllers/search_controller.rb Outdated Show resolved Hide resolved
app/services/search/query_builders/chat_channel_membership.rb Outdated Show resolved Hide resolved
app/services/search/query_builders/chat_channel_membership.rb Outdated Show resolved Hide resolved
app/services/search/query_builders/chat_channel_membership.rb Outdated Show resolved Hide resolved
@sarthology
Copy link
Contributor Author

@mstruve Implemented what we have discussed.

@sarthology sarthology requested a review from mstruve May 11, 2020 12:44
benhalpern
benhalpern approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great, figured it out. Looks good to me.

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels May 11, 2020
@benhalpern benhalpern merged commit 90d60bf into forem:master May 11, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels May 11, 2020
@thomasbnt
Copy link
Contributor

Youhouu 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parasgr-code Parasgr-code Parasgr-code left review comments

@benhalpern benhalpern benhalpern approved these changes

@citizen428 citizen428 Awaiting requested review from citizen428

@rhymes rhymes Awaiting requested review from rhymes

@mstruve mstruve Awaiting requested review from mstruve

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sarthology @mstruve @benhalpern @thomasbnt @Parasgr-code