Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mentorship area of user internal view #926

Merged
merged 2 commits into from Oct 15, 2018

Conversation

@benhalpern
Copy link
Collaborator

commented Oct 15, 2018

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Minor design tweaks of internal view

<h2> Possible Mentors </h2>
<% count = 0 %>
<% User.where(offering_mentorship: true).order("mentor_form_updated_at DESC").each do |possible_mentor| %>
<% break if count > 18 %>
<% User.where(offering_mentorship: true).where.not(mentee_form_updated_at: nil).order("mentor_form_updated_at DESC").each do |possible_mentor| %>

This comment has been minimized.

Copy link
@Zhao-Andy

Zhao-Andy Oct 15, 2018

Contributor

This should be menTOR_form_updated_at right?

This comment has been minimized.

Copy link
@benhalpern

benhalpern Oct 15, 2018

Author Collaborator

Yeah good call

@benhalpern benhalpern merged commit dee58c0 into master Oct 15, 2018
7 checks passed
7 checks passed
Travis CI - Pull Request Build Passed
Details
WIP ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 86%
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
@maestromac maestromac deleted the ben/update-mentorships branch Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.