Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to download the model #18

Closed
thepushkarp opened this issue Sep 14, 2021 · 1 comment
Closed

Add a flag to download the model #18

thepushkarp opened this issue Sep 14, 2021 · 1 comment
Projects

Comments

@thepushkarp
Copy link
Owner

Currently, if the model is not downloaded, the program downloads it during the first run, in the middle of the "Retrieving the commits ..." status mesage.

This can be improved by adding a flag through which the user can download/redownload the model when they need it.

Additionally, the program should prompt the user when it is run without downloading the weights with a choice to download it now or to abort the program.

@thepushkarp thepushkarp created this issue from a note in To Do (To do 🔧) Sep 14, 2021
@thepushkarp thepushkarp moved this from To do 🔧 to Considering 💡 in To Do Sep 18, 2021
@thepushkarp thepushkarp moved this from Considering 💡 to Done 🎉 in To Do Sep 18, 2021
@thepushkarp
Copy link
Owner Author

the sentence_bert currently does not have explicit control on when to download the models. When loading the models, it downloads if it does not find it already.

Therefore, in #21, I have loaded the model before the "Retrieving the commits ..." status message so that the download progress bar on first use can be seen clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
To Do
Done 🎉
Development

No branches or pull requests

1 participant