-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Custom DSL instead of Inheriting NUnit.Framework.Is #57
Comments
Hey @lilasquared, Sorry for the late reply, had a bit of a break and only focused on bugs for a bit. I'm not sure how/when to release this though. It would be a breaking change if I got rid of Maybe I'll add the new Then in a future major bump I'll remove the Thoughts? |
I think that makes the most sense. Thanks!
|
@all-contributors please add @lilasquared for ideas |
I've put up a pull request to add @lilasquared! 🎉 |
Released in v2.3.0 |
Is your feature request related to a problem? Please describe.
Suppose I had multiple NUnit extensions similar to Snapper, I would not be able to use all
Is
DSL methods in a single file without using FQDN of theIs
Classex:
Assert.That(obj, Snapper.Nunit.Is.EqualToSnapshot());
Describe the solution you'd like
I think it would be more declarative and composable to have a custom class, something specific to the domain of Snapper.
ex:
Assert.That(obj, Matches.Snapshot());
Assert.That(obj, Matches.ChildSnapshot("some-snap"));
Great work with this library, I was actually the one who opened nunit/nunit#2392 in the Nunit repo, and this is exactly what I was envisioning!
The text was updated successfully, but these errors were encountered: