Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet permission declared but not used? #209

Closed
t-m-w opened this issue Aug 16, 2022 · 1 comment
Closed

Internet permission declared but not used? #209

t-m-w opened this issue Aug 16, 2022 · 1 comment

Comments

@t-m-w
Copy link

t-m-w commented Aug 16, 2022

This app's manifest declares that it uses android.permission.INTERNET, but there doesn't appear to be any network functionality. If this permission is intended, it could be helpful to describe what it's for; otherwise, removing it seems reasonable for security- and privacy-conscious users.

@therealbluepandabear
Copy link
Collaborator

therealbluepandabear commented Aug 16, 2022

This app's manifest declares that it uses android.permission.INTERNET, but there doesn't appear to be any network functionality. If this permission is intended, it could be helpful to describe what it's for; otherwise, removing it seems reasonable for security- and privacy-conscious users.

It uses the internet permission for the 'Import Lospec Palette' functionality which uses Volley. To use Volley you must declare android.permission.INTERNET.

I used to write in the README.md file what the permission meant, but I didn't think it was that important as the code is open source.

I do wish android.permission.INTERNET would be a runtime/dangerous permission, but it's not -- and that's out of my control as I do not work for Google.

Code: https://github.com/therealbluepandabear/PixaPencil/blob/master/app/src/main/java/com/therealbluepandabear/pixapencil/activities/canvas/onoptionsitemselected/CanvasActivity%2BonImportLospecPaletteOptionsItemSelected.kt

I have converted this into a discussion, so please use discussions for these types of open-ended questions 😉

Repository owner locked and limited conversation to collaborators Aug 16, 2022
@therealbluepandabear therealbluepandabear converted this issue into discussion #210 Aug 16, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants