Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License/Upstream to ESPHome #1

Closed
brotherdust opened this issue Sep 17, 2021 · 2 comments
Closed

License/Upstream to ESPHome #1

brotherdust opened this issue Sep 17, 2021 · 2 comments

Comments

@brotherdust
Copy link

Hello!
Have you considered, or, are interested in, turning this into a component and submitting it to ESPHome?

If not, I have some experience writing them and would like to do so; but I'm cautious about doing so with code that has no license statement. Would you mind setting your license so I know what is OK to do with your code?

Thanks much!

@TheRealWaldo
Copy link
Owner

@brotherdust definitely interested in getting the AMG8833 and a few other sensors into ESPHome, and I have been wanting to do so and did start a project for it; would be happy to work with you to do get it working!

@TheRealWaldo
Copy link
Owner

I've just pushed the work towards converting this into an external component so far to https://github.com/TheRealWaldo/AMG8833-ESPHOME/tree/external_component

There are a few things that I still need to complete.

I want to figure out if it's okay to immediately publish the state from the sensors rather than wait for polling, and this would be best for both the camera and person detection. I think it's as simple as adding the publish in the loop instead of the update, but I need to experiment and confirm if there is any precedent to doing that.

If not, I'll have to do some refactoring to break those sensors into individual classes.

The text_sensor I'm using for the camera needs some love, as does the root sensor component.

Lastly, I've got to port the library in since ESPHome does not allow for external libraries.

Repository owner locked and limited conversation to collaborators Nov 23, 2022
@TheRealWaldo TheRealWaldo converted this issue into discussion #11 Nov 23, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants