Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my.awqlOptions being overwritten with 2 parallel calls #8

Open
joeycozza opened this issue Jun 29, 2015 · 3 comments
Open

my.awqlOptions being overwritten with 2 parallel calls #8

joeycozza opened this issue Jun 29, 2015 · 3 comments

Comments

@joeycozza
Copy link

The problem occurs with 2 separate calls to self.awql. my.awqlOptions gets overwritten there, then later
lib/googleadwords.js line 130 sets the variable my.awqlOptions to an empty object, so a race condition is happening.

It seems like it would be better to have the options get passed into _sendAWQL instead of using single modular level variable.

@therebelrobot
Copy link
Owner

Good catch. I'll refactor that in soon.

@AlonMiz
Copy link

AlonMiz commented Sep 12, 2016

Any ideas solving that issue?
Making each call forcing a delay of at least 1.5 secs.

@therebelrobot
Copy link
Owner

@AlonMiz This module is no longer being actively maintained. Please refer to https://github.com/therebelrobot/google-adwords#google-adwords for more info. If you'd like to take up maintaining it, let me know, I just don't have the bandwidth for it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants