Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument naming convention in pycthermopack wrappers #130

Open
ailoa opened this issue Feb 27, 2024 · 1 comment
Open

Argument naming convention in pycthermopack wrappers #130

ailoa opened this issue Feb 27, 2024 · 1 comment

Comments

@ailoa
Copy link
Contributor

ailoa commented Feb 27, 2024

In the next major version release, consider making the python interfaces more uniform. The argument for mol numbers is now sometimes called n, sometimes x, and sometimes z.

@vegardjervell
Copy link
Collaborator

I agree that we should be consistent on using x vs. z for methods that expect molar composition, but think we should keep n vs. z separate to indicate that some methods expect mol numbers, and return extensive variables, while others expect molar composition and return intensive variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants