Enhancement: make Actions taggable

[GoogleCodeExporter]

It's very good that CocosNodes are taggable, this helps a lot at times.

As a heavy user of Actions, I miss the same kind of support. For example, if I 
want to remove only a 
certain kind of action from a collection of nodes I need to manage a separate 
array. This adds 
complexity to my code and eats away memory.

Included patch makes actions taggable and adds support for managing them in 
nodes.

Note: In the future, it might be best to make the names of methods acting on 
child nodes more 
explicit. removeAll and removeAndStopAll are especially confusing because they 
don't tell you what 
they stop (child nodes? actions? timers?). removeAllChildren is a lot clearer 
to me.

Original issue reported on code.google.com by valentin...@gmail.com on 22 Feb 2009 at 9:45

Attachments:

• taggable_actions.diff

[GoogleCodeExporter]

Thanks. If it doesn't break the API -> v0.7.1, else v0.8

Original comment by ricardoq...@gmail.com on 27 Feb 2009 at 10:53

• Changed state: Accepted
• Added labels: Component-Actions, Milestone-Release0.7.1

[GoogleCodeExporter]

Original comment by ricardoq...@gmail.com on 27 Feb 2009 at 10:53

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

fixed in r663

Original comment by ricardoq...@gmail.com on 12 Mar 2009 at 2:20

• Changed state: Fixed

[GoogleCodeExporter]

Seems like you missed getActionByTag & stopActionByTag.

Original comment by valentin...@gmail.com on 12 Mar 2009 at 3:02

[GoogleCodeExporter]

yes. fixed in r666.

Original comment by ricardoq...@gmail.com on 13 Mar 2009 at 5:56

[GoogleCodeExporter]

Great! I reviewed the code, some bugs were introduced, actionsToRemove needs to 
be
taken into account otherwise you run the risk of:
* adding the same action twice to actionToRemove on repeated calls to 
stopAction[ByTag]
* accessing an action after it's been removed.

refixed in r685

Original comment by valentin...@gmail.com on 14 Mar 2009 at 10:13