Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jstype = JS_STRING] type Compile error #2

Closed
chenxyzl opened this issue Nov 29, 2019 · 6 comments · Fixed by #57
Closed

[jstype = JS_STRING] type Compile error #2

chenxyzl opened this issue Nov 29, 2019 · 6 comments · Fixed by #57
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@chenxyzl
Copy link

chenxyzl commented Nov 29, 2019

int64 result_per_page = 3 [jstype = JS_STRING];

Still compiled to number

get result_per_page(): number | undefined { return pb_1.Message.getFieldWithDefault(this, 3, undefined) as number | undefined; }
set result_per_page(value: number) { pb_1.Message.setField(this, 3, value); }

@thesayyn
Copy link
Owner

thesayyn commented Dec 3, 2019

Thank you for the issue and that is something we should be able to do since Javascript does not support 64-bit integers. I will add this to the roadmap. Also, PR is appreciated if you can send one :)

@chenxyzl
Copy link
Author

chenxyzl commented Dec 4, 2019

I'm going to do it at this weekend。

@chenxyzl
Copy link
Author

chenxyzl commented Dec 6, 2019

“[jstype = JS_STRING]” support already added;
But I don't know how to test on the new version;
pr has submit

@thesayyn
Copy link
Owner

Hey @chenxyzl just send a PR. I will assist you in testing.

@chenxyzl
Copy link
Author

OK, PR submitted

@thesayyn thesayyn added the bug Something isn't working label Feb 13, 2020
@thesayyn thesayyn added help wanted Extra attention is needed priority: 1 labels Apr 21, 2021
@thesayyn
Copy link
Owner

closed by #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants