-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish oneof support #48
Comments
P.S. if it is any help, if you'd write a "pseudo code" commit adding this functionality, I could complete that. Not sure if it would save you time, but wanted to offer :) |
Hey, thank you for opening this. We had a brief conversation on another issue. It makes more sense to continue the conversation here.
I can assist you on the way if you could open up a draft pull request. |
Hey @melonmouse When you have some time, could you join the discussion at #39 about one-of-fields? @melonmouse I have sent PR for this feature on #53 |
Sahin, sorry to be late getting to this, I've been off for the summer.
I believe it should be the case that:
The type of TypedValue.value should be: number | string | boolean | void [or | undefined? i'm not an expert on that ] |
Thanks so much for working on this project! Hope this bug will help :). I looked at your code for a bit to see if I could write you a pull request, but wasn't sure where to start.
To complete oneof support, there should be helper functions to determine what case is set.
https://developers.google.com/protocol-buffers/docs/reference/javascript-generated#oneof
So taking the example from above:
There should be a generated enum representing the cases, so for the above example:
And a getter that returns the enum value that is currently set, getAvatarCase().
The text was updated successfully, but these errors were encountered: