Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Node 20.x #42

Open
thescientist13 opened this issue Dec 24, 2023 · 0 comments · May be fixed by #43
Open

support Node 20.x #42

thescientist13 opened this issue Dec 24, 2023 · 0 comments · May be fixed by #43
Labels
enhancement New feature or request

Comments

@thescientist13
Copy link
Owner

thescientist13 commented Dec 24, 2023

Summary

Would like to be able to extend the GitHub Actions matrix to include Node 20.x

Details

Had tried this but kept getting this issue on Windows only :/
https://github.com/thescientist13/gallinago/actions/runs/7317046295/job/19932206454

  1 failing

  1) CLI Fixture
       default options with relative path
         "before all" hook in "default options with relative path":
     Error: done() called multiple times in hook <CLI Fixture default options with relative path "before all" hook in "default options with relative path"> of file D:\a\gallinago\gallinago\test\cases\runner-cli\runner.cli.spec.js; in addition, done() received error: Error: read ECONNRESET
    at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
  errno: -4077,
  code: 'ECONNRESET',
  syscall: 'read',
  uncaught: true
}
      at process.emit (node:events:514:28)
      at process._fatalException (node:internal/process/execution:178:25)

Interestingly, all the assertions are actually passing

  CLI Fixture
    default options with relative path
      1) "before all" hook in "default options with relative path"
      √ should have created the output folder
      √ should only copy 3 files
      √ should have an .editorconfig file
      √ should have an .eslintrc file
      √ should have .mocharc file
      √ should delete the output directory when told
    setup with setupFiles
      √ should have created the output folder
      √ should only copy 4 files
      √ should have an .editorconfig file
      √ should have an .eslintrc file
      √ should have .mocharc file
      √ should have webcomponents-bundle.js file
      √ should delete the setup file we provided
@thescientist13 thescientist13 added the enhancement New feature or request label Dec 24, 2023
@thescientist13 thescientist13 changed the title support Node >=20 support Node 20.x Dec 24, 2023
@thescientist13 thescientist13 linked a pull request Dec 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant