Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test coverage needed for Promise.reject handling in Runner #9

Open
1 of 5 tasks
thescientist13 opened this issue Oct 28, 2020 · 0 comments
Open
1 of 5 tasks
Labels
chore good first issue Good for newcomers

Comments

@thescientist13
Copy link
Owner

thescientist13 commented Oct 28, 2020

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Documentation
  • Bug
  • Other (please clarify below)

Summary

Improve unit testing coverage (primarily around error handling)

Details

coverage reports shows some area for branch coverage improvement in runner.js

------------|---------|----------|---------|---------|-------------------
File        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------|---------|----------|---------|---------|-------------------
All files   |    92.5 |    76.92 |     100 |    92.5 |                   
 src        |     100 |      100 |     100 |     100 |                   
  index.js  |     100 |      100 |     100 |     100 |                   
 src/lib    |   92.11 |    76.92 |     100 |   92.11 |                   
  runner.js |   92.11 |    76.92 |     100 |   92.11 | 26,53,73          
------------|---------|----------|---------|---------|-------------------

=============================== Coverage summary ===============================
Statements   : 92.5% ( 37/40 )
Branches     : 76.92% ( 10/13 )
Functions    : 100% ( 10/10 )
Lines        : 92.5% ( 37/40 )
================================================================================

Mostly around handling instances of Promise.reject. Would love to get this above 90% 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant