Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte size mismatch in ap_realmode assembly #57

Closed
kevinaboos opened this issue Sep 2, 2018 · 4 comments
Closed

Byte size mismatch in ap_realmode assembly #57

kevinaboos opened this issue Sep 2, 2018 · 4 comments

Comments

@kevinaboos
Copy link
Member

@snoword there's a potentially major bug in ap_realmode, line 134. The linker throws a warning (it should probably be an error) because you're comparing a byte to the value 600, which is too large to fit in a byte. You should use the proper type, not byte but maybe a word? I dunno how big it is.

@kevinaboos kevinaboos assigned kevinaboos and unassigned kevinaboos Sep 2, 2018
@snoword
Copy link
Collaborator

snoword commented Sep 16, 2018

I have solved it in the framebuffer branch

@kevinaboos
Copy link
Member Author

Close it with the commit id.

@snoword snoword closed this as completed Sep 16, 2018
@snoword
Copy link
Collaborator

snoword commented Sep 16, 2018

Closed by 3876562

@kevinaboos kevinaboos reopened this Sep 16, 2018
@kevinaboos
Copy link
Member Author

kevinaboos commented Sep 16, 2018

To close with a commit id, you paste the commit hash here, or in the actual commit message you can say something like Closes <sha>.

I've edited your comment to fix this.

kevinaboos pushed a commit that referenced this issue Sep 20, 2018
* Improve code comments and documentation

* Closes #57.
kevinaboos pushed a commit that referenced this issue Sep 1, 2020
* Improve code comments and documentation

* Closes #57.
kevinaboos pushed a commit that referenced this issue Sep 1, 2020
* Improve code comments and documentation

* Closes #57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants