-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error with distribute.sh #3
Comments
Thanks for these suggestions. Checking that they are equal is probably the way to go. Maybe a warning, asking for confirmation to proceed if the lengths don’t match. And, we could exit the loop early if we hit the end of either list. |
@skeletoncrewrip ill try this issue! |
thanks @migui3230! |
Closed by #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the recipients list is smaller than the minted addresses, it looks like the action has failed.
(Ideally you don't want the recipients list to be smaller than the list of minted tokens, but still it makes sense to make the error more obvious than a loop of errors)
Proposed solution:
Loop over the recipients list length instead of the token list length
Or - check if the recipient list is the same length as the minted token list and stop the script if they're not equal?
The text was updated successfully, but these errors were encountered: