Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

馃憢 from textproto-grammar #4

Closed
thejustinwalsh opened this issue Sep 9, 2021 · 7 comments
Closed

馃憢 from textproto-grammar #4

thejustinwalsh opened this issue Sep 9, 2021 · 7 comments

Comments

@thejustinwalsh
Copy link

I got really excited and created this without even knowing that vscode-pbtxt was a thing.

https://github.com/thejustinwalsh/textproto-grammar

Feel free to grab anything and add to yours if you find it useful. Notably the fenced code block support that was contributed.

Anyhow, two can exist, and who knows you are I may diverge wildly at some point with whatever our project needs, but wanted to reach out! Great minds think alike!

@thesofakillers
Copy link
Owner

Hi, looks awesome! I no longer use VSCode so I doubt I'll be maintaining this repo, which is a port anyway. Does your implementation cover everything mine does? If so, I'll probably archive this repo and redirect users to yours. What do you think?

@thejustinwalsh
Copy link
Author

Oh dang! The universe just out there working things out. Haha.

Your repo has some tests, and that PR for single quotes, let me pull in tests and verify that fix and I'll give you the good word here in a few.

@thejustinwalsh
Copy link
Author

This refactor should fix nesting and single quote strings. Sitting on it as it is late, and will work up a release after some more testing.
thejustinwalsh/textproto-grammar#6

@thejustinwalsh
Copy link
Author

Updated to support single quotes and correctly highlights your test file.
https://github.com/thejustinwalsh/textproto-grammar/releases/tag/v0.0.6

Published on the market place as well.

@thesofakillers
Copy link
Owner

Awesome, just give me a thumbs up whenever and i'll archive this repo and add a note to the readme redirecting to yours 馃憤馃徎

@thejustinwalsh
Copy link
Author

@thesofakillers one final change to the highlight and keywords, v0.0.7 heading to the marketplace.
textproto-grammar now supports and renders like vscode-pbtxt and adds support for herodoc and markdown code fences.

Good to go!

@thesofakillers
Copy link
Owner

thesofakillers commented Sep 15, 2021

note added to readme in bffc90d. Also published updated readme to marketplace. Archiving after this comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants