Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Use snd-hda-codec-hdmi for SOF HDMI/DP support #1123

Closed
kv2019i opened this issue Aug 12, 2019 · 3 comments
Closed

[enhancement] Use snd-hda-codec-hdmi for SOF HDMI/DP support #1123

kv2019i opened this issue Aug 12, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request reuse legacy HDMI codec Reuse legacy HDA HDMI codec driver snd-hda-codec-hdmi

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 12, 2019

There are currently two i915 HDMI codec implementations in upstream kernel, snd-hda-codec-hdmi (sound/pci/hda) and hdac_hdmi (sound/soc/codecs).

SOF is currently using the latter to enable HDMI/DP features for Intel HDA platforms.

Maintaining two codecs for the same hardware is not efficient as a fair amount of bugfixes and hw quirks are maintained for different hardware generations. And as of now, the snd-hda-codec-hdmi driver is much more widely used.

SOF should move to use the snd-hda-codec-hdmi driver as well and eventually to merge the drivers. SOF already reuses the HDAC library for HDA audio and HDMI/DP is programmed via HDA interface on the i915 hardware, so using this solution also for HDMI makes sense.

@fredoh9
Copy link
Collaborator

fredoh9 commented Aug 12, 2019

I'm attaching more logs for ICL HDA. This is not 100% reproducible, only sometimes I can see this failures.

[    5.556801] sof-audio-pci 0000:00:1f.3: error: codec #1 probe error, ret: -5
[    5.556804] sof-audio-pci 0000:00:1f.3: Turning i915 HDAC power off
[    5.556957] sof-audio-pci 0000:00:1f.3: error: no matching ASoC machine driver found - aborting probe
[    5.556958] sof-audio-pci 0000:00:1f.3: error: failed to get machine info -19
[    5.556959] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -19

0809_icl6_hdmi_error.log
0812_icl5_hdmi_error.log
0812_icl5_no_soundcard.log
0812_icl6_booting_ok.log

@kv2019i
Copy link
Collaborator Author

kv2019i commented Aug 27, 2019

New patch series uploaded on #1155 -- see progress update in the PR description.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Nov 4, 2019

This enhancement is now implemtend with #1404 and #1422

@kv2019i kv2019i closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reuse legacy HDMI codec Reuse legacy HDA HDMI codec driver snd-hda-codec-hdmi
Projects
None yet
Development

No branches or pull requests

3 participants