Skip to content
This repository has been archived by the owner on May 8, 2021. It is now read-only.

Adding Back True Transparency Breaks W3M/Ranger Image Viewing #199

Closed
noctuid opened this issue Nov 2, 2014 · 20 comments
Closed

Adding Back True Transparency Breaks W3M/Ranger Image Viewing #199

noctuid opened this issue Nov 2, 2014 · 20 comments

Comments

@noctuid
Copy link

noctuid commented Nov 2, 2014

With commit 7612e90, images can no longer be displayed in terminal. Image preview isn't supposed to work with transparency, but even with transparency disabled (1 for the alpha channel) it doesn't work.

@thestinger
Copy link
Owner

@angelic-sedition: I'll work around that soon by having it only do this when transparency is enabled.

@esn89
Copy link

esn89 commented Nov 3, 2014

@angelic-sedition thanks for bringing this up
@thestinger thanks for the work around. looking forward

@spcmd
Copy link

spcmd commented May 27, 2015

Any update on this?

@autrimpo
Copy link

To continue the issues from my pull request - checking all the colors for possible transparency is easy, however it seems that changing the widget's visual has no effect after it has been created and drawn.
This makes switching between transparent and opaque mode without restarting termite quite difficult.
Maybe recreating the window and the widget after reloading the config could work, however I have no idea what effect it would have on the terminal and its contents (possibly erasing all scrollback?) and if such behaviour is even desirable.

@thestinger
Copy link
Owner

You might have to hide and show the widget again, I'm not sure.

@autrimpo
Copy link

Unfortunately, hiding and showing the widget does not work.

I understand that you don't want to regress existing functionality, so if anybody wants to use termite with ranger and doesn't care about transparency (or the need to restart) they can use my ranger-fix branch which uses the system visual as long as no color has transparency.

Better, if anybody has an idea how this could be solved, I'd love to work on it some more and see it merged upstream, but right now I can't really see that happening.

@esn89
Copy link

esn89 commented Jun 15, 2015

i really don't care for termite with transparency, i would just like the pictures to show up on ranger. your ranger-fix does just that?

@autrimpo
Copy link

Yes, as long as all your colors are using the #rrggbb format (rgba(r,g,b,1) will probably work as well).

@timokau
Copy link

timokau commented Jun 19, 2015

Does this mean this won't be implemented in the main repo? I also don't really care for transparency but I'd rather not use some fork if it can be avoided.

@autrimpo
Copy link

In the current state? Most probably not.
I'd love to see this fixed upstream as well, but the current solution does not allow switching between "transparent mode" (which does not work with ranger), and "non-transparent mode" (which does), without restarting termite, which @thestinger (rightfully) sees as regression. So until we can find a solution to this, I don't think he will merge my changes.

@timokau
Copy link

timokau commented Jun 19, 2015 via email

@thestinger
Copy link
Owner

FWIW, sxiv has Vim-like keybindings and a nice thumbnail preview mode.

@noctuid
Copy link
Author

noctuid commented Aug 31, 2015

@autrimpo Thanks for the ranger-fix branch! I'll use this for now.

@andresmrm
Copy link

+1

1 similar comment
@bb010g
Copy link

bb010g commented Dec 1, 2015

👍

@fmthoma
Copy link

fmthoma commented Dec 19, 2015

This is really a bug in w3m (which is used by ranger to display images). See https://github.com/hut/ranger/issues/86 for details.

For Debian users, it has been fixed in the w3m development repo: tats/w3m@e24b406.

@thestinger
Copy link
Owner

Thanks for the update, I'll just close this issue then.

@fmthoma
Copy link

fmthoma commented Dec 28, 2015

It seems like I was a little too fast with my comment above: There were issues with w3m crashing in terminals with 32bit color that now have been resolved, but image display still does not seem to work according to @noctuid.

@Vintodrimmer
Copy link

Vintodrimmer commented Jul 8, 2017

Good day,

Is there still no way to fix this in the main repo? I have the transparency option commented out #background = rgba(63, 63, 63, 0.8), but pictures do not show. In some cases it becomes fully transparent and just shows me the wallpaper (or whatever is behind) where the image should probably be. If I turn the compton off, I just get the blackness of the terminal instead of the picture preview.

a picture

@thestinger
Copy link
Owner

It's not a Termite issue.

Repository owner locked and limited conversation to collaborators Jul 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants