fix(SharedMethods): find components in loading scenes #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit This message was auto-generated by https://gitcop.com |
kristianpd
force-pushed
the
fix-loading-scene-sharedmethods
branch
from
23513dd
to
64a5f38
Compare
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit This message was auto-generated by https://gitcop.com |
Change finding components to look in scenes that are loading or loaded.
kristianpd
force-pushed
the
fix-loading-scene-sharedmethods
branch
from
64a5f38
to
59951a2
Compare
|
@bddckr happy with this? |
bddckr
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a change to find even inactive objects in all scenes as opposed to just the currently loaded one (#1725).
In doing so I was assuming that the scene would be
isLoadedby the time i wanted to do the search. As discovered by @bddckr, theAwake/Startmethods run before the sceneisLoadedand this resulted in the shared methods being unable to find certain components duringAwakeandStart.This gets rid of that condition, since scenes retrieved using
sceneCountandGetSceneAtare either loading or loaded.This also refactors the method to avoid unnecessary iteration when only searching the active scene, and also renames the helper method.
@bddckr @thestonefox