fix(UnityXR): fix UnityXR stack overflow #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit This message was auto-generated by https://gitcop.com |
jamre
force-pushed
the
unityxr-stack-overflow
branch
from
34c4724
to
7cff464
Compare
|
I did not have a look at the changes done but separate things should be in separate commits and in this case probably even in separate PRs. |
Don't allow the SetTrackedControllerCaches method to re-enter while it's executing since it's possible to call itself and get stuck.
jamre
force-pushed
the
unityxr-stack-overflow
branch
from
7cff464
to
3ba8299
Compare
|
I un-squashed them and I'll make a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTC Vive controller joystick names as reported by Unity 2017.4.2f2.
Don't allow the SetTrackedControllerCaches method to re-enter while it's executing since it's possible to call itself and get stuck.
fixes #1764