Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seasonName is missing in episode record #270

Closed
rednoah opened this issue Jan 8, 2023 · 5 comments
Closed

seasonName is missing in episode record #270

rednoah opened this issue Jan 8, 2023 · 5 comments
Assignees
Labels
bug Something isn't working ticketed Issue has been ticketed in Jira

Comments

@rednoah
Copy link

rednoah commented Jan 8, 2023

The "seasonName": "string", property seems to be broken. It's no longer included in the API response.

Series with season names:
https://thetvdb.com/series/natsumes-book-of-friends#seasons

API endpoint:

https://api4.thetvdb.com/v4/series/82788/episodes/default/eng?page=0

"seasonName": "..." is missing from the response:

         {
            "id":382778,
            "seriesId":82788,
            "name":"The Cat and the Book of Friends",
            "aired":"2008-07-07",
            "runtime":23,
            "nameTranslations":null,
            "overview":"Natsume discovers that the heirloom \"Book of Friends\" that his grandmother, Reiko, gave him possesses the names of the spirits she defeated and bound to her will. Assisted by a cat whom Natsume addresses as Nyanko-Sensei (lit. Master Little Meow), Natsume aims to return all of the names to their rightful owners.",
            "overviewTranslations":null,
            "image":"/banners/episodes/82788/382778.jpg",
            "imageType":11,
            "isMovie":0,
            "seasons":null,
            "number":1,
            "seasonNumber":1,
            "lastUpdated":"2022-09-25 04:06:02",
            "finaleType":null,
            "year":"2008"
         },

Response JSON:
https://pastebin.com/UjDLciVM

@rednoah
Copy link
Author

rednoah commented Jan 8, 2023

Follow-Up: The "original language" end point actually works and does include the seasonName property in original language:

https://api4.thetvdb.com/v4/series/82788/episodes/default?page=0

However, the seasonName property is omitted in the response whenever I request language-specific episode information.

@antheaezzell antheaezzell added enhancement New feature or request ticketed Issue has been ticketed in Jira labels Jan 10, 2023
@rednoah
Copy link
Author

rednoah commented Apr 18, 2023

Any updates? Shouldn't be too hard to fix since it's already working if no language is specified. Just do the same if a language is specified.

@antheaezzell
Copy link

I've ticketed the issue @rednoah and we will try to get a fix in soon.

Internal ticket for our reference: https://mediamorph.atlassian.net/browse/TVD-3695

@antheaezzell antheaezzell added bug Something isn't working and removed enhancement New feature or request labels Apr 18, 2023
@antheaezzell
Copy link

@rednoah this improvement was pushed out in this release - https://github.com/thetvdb/v4-api/releases/tag/v4.7.6 Please let us know if there are any problems.

@rednoah
Copy link
Author

rednoah commented May 16, 2023

Thanks. Looks like it started working now. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ticketed Issue has been ticketed in Jira
Projects
None yet
Development

No branches or pull requests

3 participants