Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Movies as Specials Are Missing Title and Overview #289

Closed
markus101 opened this issue Apr 27, 2023 · 14 comments
Closed

Linked Movies as Specials Are Missing Title and Overview #289

markus101 opened this issue Apr 27, 2023 · 14 comments
Assignees
Labels
bug Something isn't working ticketed Issue has been ticketed in Jira

Comments

@markus101
Copy link

Specials that are movies linked to a series are missing both title and overview, in addition isMovie is 0.

Specials on TheTVDB:
https://thetvdb.com/series/violet-evergarden/seasons/official/0

API route requested:
https://api4.thetvdb.com/v4/series/330139/episodes/official/eng

For brevity, these are the 3 specials that are returned, the first is a "proper" episode with all the expected information, the second and third are incomplete.

[
	{
		"id": 6497072,
		"seriesId": 330139,
		"name": "OVA: Surely, Someday You Will Understand \"Love\"",
		"aired": "2018-07-04",
		"runtime": 35,
		"nameTranslations": null,
		"overview": "Violet is hired by Irma, a famous opera singer, to write a letter for her for a soldier missing in action. However, Irma's requests for the letter are both vague and complex, making it difficult for Violet to write a letter that can satisfy her despite numerous rewrites.",
		"overviewTranslations": null,
		"image": "/banners/series/330139/episodes/5e918b8bea666.jpg",
		"imageType": 11,
		"isMovie": 0,
		"seasons": null,
		"number": 1,
		"seasonNumber": 0,
		"lastUpdated": "2023-04-08 20:44:33",
		"finaleType": "season",
		"airsBeforeSeason": 1,
		"airsBeforeEpisode": 5,
		"year": "2018"
	},
	{
		"id": 9513839,
		"seriesId": 330139,
		"name": null,
		"aired": "2019-09-06",
		"runtime": 90,
		"nameTranslations": null,
		"overview": null,
		"overviewTranslations": null,
		"image": null,
		"imageType": null,
		"isMovie": 0,
		"seasons": null,
		"number": 2,
		"seasonNumber": 0,
		"lastUpdated": "2022-12-19 21:39:40",
		"finaleType": null,
		"airsAfterSeason": 1,
		"year": "2019"
	},
	{
		"id": 9513840,
		"seriesId": 330139,
		"name": null,
		"aired": "2020-09-18",
		"runtime": 140,
		"nameTranslations": null,
		"overview": null,
		"overviewTranslations": null,
		"image": null,
		"imageType": null,
		"isMovie": 0,
		"seasons": null,
		"number": 3,
		"seasonNumber": 0,
		"lastUpdated": "2022-12-19 21:41:56",
		"finaleType": "season",
		"airsAfterSeason": 1,
		"year": "2020"
	}
]

This issue also affects other series, such as https://thetvdb.com/series/that-time-i-got-reincarnated-as-a-slime/seasons/official/0

@antheaezzell antheaezzell added bug Something isn't working ticketed Issue has been ticketed in Jira labels May 1, 2023
@antheaezzell
Copy link

@markus101 this appears to be a bug in the API. It's been ticketed and I'll let you know when it is out.
https://whipmedia.atlassian.net/browse/TVD-3714

@ekleop
Copy link

ekleop commented May 17, 2023

moreover, episodes endpoint (https://api4.thetvdb.com/v4/series/330139/episodes/default) without "/eng" language variable has "linkedMovie" key for the movie entries. In this one it's lost.

@antheaezzell
Copy link

I've added the data @ekleop but this ticket is still in grooming.

@Marly212
Copy link

Marly212 commented Jun 7, 2023

Is there anything new to resolve this issue? It's already 6 weeks old now.

@antheaezzell
Copy link

This will be handled in a few weeks @Marly212. We are working with reduced resources at the moment.

@Marly212
Copy link

Marly212 commented Aug 2, 2023

Any new Updates regarding this issue?

@antheaezzell
Copy link

We have a PR against it, but our platform engineer is on vacation. I think it'll be another week. My apologies @Marly212

@Marly212
Copy link

Is your platform engineer back from vacation yet?

@antheaezzell
Copy link

@Marly212 @ekleop @markus101 we just released this last night. Please let me know if you continue to experience issues.

https://github.com/thetvdb/v4-api/releases/tag/v4.7.8

@fatSquirrel42
Copy link

Disclaimer: I can't test these things directly with the API because I don't have an API key.

I've noticed the same error with my workflow, which is organizing my files with Sonarr and importing them into Jellyfin. I also did my testing with the Violet Evergarden specials. https://thetvdb.com/series/violet-evergarden/seasons/official/0

The "name" field appears to be fixed. At least Sonarr gets the proper titles. Jellyfin can't find the name for https://thetvdb.com/series/violet-evergarden/episodes/9513840 but that might be a problem on Jellyfin's end.

I noticed that in the original post, the "image" fields were null. Have you already taken that into account? All I can say is that Jellyfin only finds one image for the non-movie special https://thetvdb.com/series/violet-evergarden/episodes/6497072 but not for the other two. I could also imagine that Jellyfin finds an image but the imageType is wrong. Maybe someone with API key can check if the "image" field for movie specials is still null or not.

@antheaezzell
Copy link

A couple of things @fatSquirrel42 .

  1. I'm not sure if Jellyfin is using the v4 API, so it's possible the name population issue is related to the legacy API which is unsupported.
  2. I think this is the expected behavior. It's pulling the episode thumb and there is only to pull.

@fatSquirrel42
Copy link

  1. You are absolutely correct. This is currently being worked on.
    Update for API v4 support jellyfin/jellyfin-plugin-tvdb#47
    Tvdb v4 migration jellyfin/jellyfin-plugin-tvdb#93

  2. Do you mean it is expected, because the linked movie page https://thetvdb.com/series/violet-evergarden/episodes/9513840 has no thumbnail. And the standalone movie page only has a poster image? https://thetvdb.com/movies/violet-evergarden-the-movie
    Are you considering adding a thumbnail, to the linked movie page?

@sktaylortrash
Copy link

@fatSquirrel42

It's expected because the linked movie: https://thetvdb.com/series/violet-evergarden/episodes/9513840 doesn't have an episode image. Simply adding one there will correct the problem of no image being available.
add image
https://imgur.com/a/t8fKsUy
There is no intent to add thumbnails directly to the movie pages themselves

@markus101
Copy link
Author

Titles and isMovie: 1 are correctly set for these titles now, but we're seeing issues where titles don't match what is on the website. Looks like someone has already opened an issue for that and I'll provide more information there.

#322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ticketed Issue has been ticketed in Jira
Projects
None yet
Development

No branches or pull requests

7 participants