Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema mismatch with the JSON response. #314

Open
scampower3 opened this issue Dec 3, 2023 · 3 comments
Open

Schema mismatch with the JSON response. #314

scampower3 opened this issue Dec 3, 2023 · 3 comments
Assignees
Labels
bug Something isn't working ticketed Issue has been ticketed in Jira

Comments

@scampower3
Copy link

scampower3 commented Dec 3, 2023

I have used NSwag to generate an API client. However, I get some issues with the as the JSON response is not what the client is expecting.

Some observed mismatches:

  1. Character: EpisodeId, MovieId and SeriesId should be nullable
  2. ParentCompany: Id should be nullable
  3. CompanyRelationShip: Id should be nullable
  4. EpisodeBaseRecord: AverageRuntime, ImageType and Runtime should be nullable
  5. EpisodeExtendedRecord: AverageRuntime, ImageType and Runtime should be nullable
  6. SearchResult: Overviews and Translations should be Dictionaries
  7. Status: Id is should be nullable
  8. Companies: Studio, Network, Production, Distributor and Special_effects should be Lists
@George-Miao
Copy link

Glad that someone has spotted the problem first. I was just about to open an issue on the search result one.

@antheaezzell antheaezzell added bug Something isn't working ticketed Issue has been ticketed in Jira labels Jan 20, 2024
@antheaezzell
Copy link

I have issued an investigatory ticket here, which we will look into. Ticket is for our internal reference.

@scampower3
Copy link
Author

scampower3 commented Feb 26, 2024

Hey, found another one:

Company: primaryCompanyType should be nullable
MovieBaseRecord: runtime should be nullable
MovieExtendedRecord: runtime should be nullable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ticketed Issue has been ticketed in Jira
Projects
None yet
Development

No branches or pull requests

4 participants