Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't publish two affected libraries at the same time #60

Closed
tomavic opened this issue Apr 17, 2023 · 4 comments
Closed

Can't publish two affected libraries at the same time #60

tomavic opened this issue Apr 17, 2023 · 4 comments

Comments

@tomavic
Copy link

tomavic commented Apr 17, 2023

Hi there ✋

I've successfully installed your package inside my nx monorepo which contains two simple libs and one app.

I am using github actions to deploy the libs with affected command.

I ran into an error when the affected command tried to publish both libraries,

Full log from here https://github.com/tomavic/enigma-nx-angular/actions/runs/4726308148/jobs/8385752785

Any ideas on how to solve this? As this contradict with the concept of having multi packages and the possibility of publishing multi package at the time is present when you have a larger project with many teams working on the same repo.

@Weetbix
Copy link
Contributor

Weetbix commented Apr 24, 2023

@tomavic I think by default affected runs in parallel, you should pass --parallel=false

I'm having success with:
npx nx run-many --target=semantic-release --parallel=false

Also I'm not sure you need to use affected itself, as this package runs affected internally, although i guess it doesnt hurt :)

@tomavic
Copy link
Author

tomavic commented Apr 24, 2023

That works perfectly 🔥 . Thanks @Weetbix

@TheUnderScorer
Copy link
Owner

Thanks, guys! I'll update the readme to mention that this plugin won't work correctly without the --parallel=false flag for multiple projects :)

@tomavic
Copy link
Author

tomavic commented Apr 25, 2023

@TheUnderScorer It would be wonderful if there is an example demo of the different cases of configuration that your plugins supports. I know there are many, but AT LEAST there should be one.

I published this monorepo (2pcks, 1 app) https://github.com/tomavic/enigma-nx-angular
And this one standolne react https://github.com/tomavic/myreads-tracker-nx-react-semantic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants