Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Clean-up the use of a database to keep client state #219

Closed
rdimitrov opened this issue Feb 10, 2022 · 2 comments
Closed

client: Clean-up the use of a database to keep client state #219

rdimitrov opened this issue Feb 10, 2022 · 2 comments

Comments

@rdimitrov
Copy link
Contributor

rdimitrov commented Feb 10, 2022

Description:

  • This is more of an implementation enhancement than an issue, but it makes sense to bring it up as it might be worth to discuss
  • The idea is to streamline and even deprecate the database usage throughout the code
  • Currently, there are several dedicated databases being managed (i.e. for keeping metadata files and keys) and it's not really necessary to have them for our use case. For example, the client caches a list of targets, which is only for non-delegated targets and likely leads to incorrect state usage. Should just do the delegated targets (DFS) search, per spec
  • Such refactoring will help by cleaning the client codebase and will remove unnecessary dependencies too
@asraa
Copy link
Contributor

asraa commented Feb 10, 2022

Also: would be nice to expose client state in a readable way (expiraitons/versions of top-level meta?)

@rdimitrov
Copy link
Contributor Author

Closing since the code base changed and is no longer relevant.

Thanks for raising this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants