Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyid_hash_algorithms #368

Closed
znewman01 opened this issue Sep 1, 2022 · 2 comments
Closed

Remove keyid_hash_algorithms #368

znewman01 opened this issue Sep 1, 2022 · 2 comments

Comments

@znewman01
Copy link
Contributor

go-tuf added keyid_hash_algorithms as a field in 2fbbd60 (June 2020); see python-tuf#848 for context. However, it never made it into the spec, and now it’s not needed due to TAP-12 (which is accepted). python-tuf removed it (python-tuf#1014); we should too.

@znewman01
Copy link
Contributor Author

@trishankatdatadog brings up a good point: be careful about backwards compat here! Old clients may expect this field.

So we should:

  • stop expecting it (client side) immediately
  • after a minor version bump, stop producing it (repo side) for new repos
  • have an option to keep producing it indefinitely, if a repo ever had it (they probably don't want to break old clients)

@rdimitrov
Copy link
Contributor

Closing since the code base changed and this is already fixed.

Thanks for raising this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants