Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify client building and installation instructions. #1285

Conversation

trishankatdatadog
Copy link
Contributor

Hello there! :)

I'm just simplifying the building and installation instructions to what worked for me.

Let me know what you think!

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "trishank_kuppusamy/simplify-client-installation-instructions" git@github.com:trishankatdatadog/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@docker-jenkins
Copy link

Can one of the admins verify this patch?

@endophage
Copy link
Contributor

Jenkins test this please

@endophage
Copy link
Contributor

LGTM pending Jenkins (which should bump the codecov too)

@endophage
Copy link
Contributor

@trishankatdatadog can you go back and add the signed off by line to the first of the two commits please.

@trishankatdatadog trishankatdatadog force-pushed the trishank_kuppusamy/simplify-client-installation-instructions branch from d808dfa to a0163c3 Compare February 1, 2018 20:23
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
@trishankatdatadog trishankatdatadog force-pushed the trishank_kuppusamy/simplify-client-installation-instructions branch from a0163c3 to 7fb0481 Compare February 1, 2018 20:27
@trishankatdatadog
Copy link
Contributor Author

done :)

@endophage
Copy link
Contributor

Jenkins test this please

@cyli
Copy link
Contributor

cyli commented Feb 5, 2018

LGTM :)

@trishankatdatadog
Copy link
Contributor Author

Thanks @cyli! Do I need to do anything else here?

@cyli
Copy link
Contributor

cyli commented Feb 6, 2018

@trishankatdatadog Nope, this is great, thank you!

@cyli cyli merged commit cfff3eb into notaryproject:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants