-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify client building and installation instructions. #1285
Simplify client building and installation instructions. #1285
Conversation
Please sign your commits following these rules: $ git clone -b "trishank_kuppusamy/simplify-client-installation-instructions" git@github.com:trishankatdatadog/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Can one of the admins verify this patch? |
Jenkins test this please |
LGTM pending Jenkins (which should bump the codecov too) |
@trishankatdatadog can you go back and add the signed off by line to the first of the two commits please. |
d808dfa
to
a0163c3
Compare
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
Signed-off-by: Trishank K Kuppusamy <trishank.kuppusamy@datadoghq.com>
a0163c3
to
7fb0481
Compare
done :) |
Jenkins test this please |
LGTM :) |
Thanks @cyli! Do I need to do anything else here? |
@trishankatdatadog Nope, this is great, thank you! |
Hello there! :)
I'm just simplifying the building and installation instructions to what worked for me.
Let me know what you think!