Rework the FIPS mode detection #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The const |
|
Ah ok, we still have a force override, will adjust. |
justincormack
force-pushed
the
fips-test
branch
from
f84a645
to
3eaf89d
Compare
|
Ok fixed up the way tests work cc @cyli |
justincormack
force-pushed
the
fips-test
branch
from
3eaf89d
to
9c40686
Compare
The best test we currently have for whether Notary is running in a FIPS compliant environment is whether the MD5 hash function is registered when crypto/md5 is linked in to the program. This function is not available in FIPS mode as it is not an allowed hash function. Fix the tests to not use environment variables but private functions instead. This allows parallel testing and is cleaner. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
fips-test
branch
from
9c40686
to
1710178
Compare
cyli
approved these changes
Mar 27, 2018
|
Thanks @justincormack LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best test we currently have for whether Notary is running in a FIPS
compliant environment is whether the MD5 hash function is registered when
crypto/md5 is linked in to the program. This function is not available
in FIPS mode as it is not an allowed hash function.
Signed-off-by: Justin Cormack justin.cormack@docker.com