Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent about Notary vs notary #1324

Merged
merged 1 commit into from Apr 3, 2018
Merged

Conversation

amouat
Copy link
Contributor

@amouat amouat commented Mar 30, 2018

Sorry, a bit OCD but it was getting to me :)

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:amouat/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@docker-jenkins
Copy link

Can one of the admins verify this patch?

Sorry, a bit OCD but it was getting to me :)

Signed-off-by: Adrian Mouat <adrian.mouat@gmail.com>
@HuKeping
Copy link
Contributor

HuKeping commented Apr 3, 2018

seems great :)

@cyli
Copy link
Contributor

cyli commented Apr 3, 2018

jenkins, test this please

Copy link
Contributor

@cyli cyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @amouat - LGTM pending CI

Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyli cyli merged commit 107dd1e into notaryproject:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants