-
Notifications
You must be signed in to change notification settings - Fork 266
/
test_updater.py
executable file
·2163 lines (1625 loc) · 93.8 KB
/
test_updater.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
#!/usr/bin/env python
# Copyright 2012 - 2017, New York University and the TUF contributors
# SPDX-License-Identifier: MIT OR Apache-2.0
"""
<Program Name>
test_updater.py
<Author>
Konstantin Andrianov.
<Started>
October 15, 2012.
March 11, 2014.
Refactored to remove mocked modules and old repository tool dependence, use
exact repositories, and add realistic retrieval of files. -vladimir.v.diaz
<Copyright>
See LICENSE-MIT OR LICENSE for licensing information.
<Purpose>
'test_updater.py' provides a collection of methods that test the public /
non-public methods and functions of 'tuf.client.updater.py'.
The 'unittest_toolbox.py' module was created to provide additional testing
tools, such as automatically deleting temporary files created in test cases.
For more information, see 'tests/unittest_toolbox.py'.
<Methodology>
Test cases here should follow a specific order (i.e., independent methods are
tested before dependent methods). More accurately, least dependent methods
are tested before most dependent methods. There is no reason to rewrite or
construct other methods that replicate already-tested methods solely for
testing purposes. This is possible because the 'unittest.TestCase' class
guarantees the order of unit tests. The 'test_something_A' method would
be tested before 'test_something_B'. To ensure the expected order of tests,
a number is placed after 'test' and before methods name like so:
'test_1_check_directory'. The number is a measure of dependence, where 1 is
less dependent than 2.
"""
# Help with Python 3 compatibility, where the print statement is a function, an
# implicit relative import is invalid, and the '/' operator performs true
# division. Example: print 'hello world' raises a 'SyntaxError' exception.
from __future__ import print_function
from __future__ import absolute_import
from __future__ import division
from __future__ import unicode_literals
import os
import time
import shutil
import copy
import tempfile
import logging
import errno
import sys
import unittest
import json
import tuf
import tuf.exceptions
import tuf.log
import tuf.formats
import tuf.keydb
import tuf.roledb
import tuf.repository_tool as repo_tool
import tuf.repository_lib as repo_lib
import tuf.unittest_toolbox as unittest_toolbox
import tuf.client.updater as updater
from tests import utils
import securesystemslib
import six
logger = logging.getLogger(__name__)
repo_tool.disable_console_log_messages()
class TestUpdater(unittest_toolbox.Modified_TestCase):
@classmethod
def setUpClass(cls):
# Create a temporary directory to store the repository, metadata, and target
# files. 'temporary_directory' must be deleted in TearDownModule() so that
# temporary files are always removed, even when exceptions occur.
cls.temporary_directory = tempfile.mkdtemp(dir=os.getcwd())
# Needed because in some tests simple_server.py cannot be found.
# The reason is that the current working directory
# has been changed when executing a subprocess.
cls.SIMPLE_SERVER_PATH = os.path.join(os.getcwd(), 'simple_server.py')
# Launch a SimpleHTTPServer (serves files in the current directory).
# Test cases will request metadata and target files that have been
# pre-generated in 'tuf/tests/repository_data', which will be served
# by the SimpleHTTPServer launched here. The test cases of 'test_updater.py'
# assume the pre-generated metadata files have a specific structure, such
# as a delegated role 'targets/role1', three target files, five key files,
# etc.
cls.server_process_handler = utils.TestServerProcess(log=logger,
server=cls.SIMPLE_SERVER_PATH)
@classmethod
def tearDownClass(cls):
# Cleans the resources and flush the logged lines (if any).
cls.server_process_handler.clean()
# Remove the temporary repository directory, which should contain all the
# metadata, targets, and key files generated for the test cases
shutil.rmtree(cls.temporary_directory)
def setUp(self):
# We are inheriting from custom class.
unittest_toolbox.Modified_TestCase.setUp(self)
tuf.roledb.clear_roledb(clear_all=True)
tuf.keydb.clear_keydb(clear_all=True)
self.repository_name = 'test_repository1'
# Copy the original repository files provided in the test folder so that
# any modifications made to repository files are restricted to the copies.
# The 'repository_data' directory is expected to exist in 'tuf.tests/'.
original_repository_files = os.path.join(os.getcwd(), 'repository_data')
temporary_repository_root = \
self.make_temp_directory(directory=self.temporary_directory)
# The original repository, keystore, and client directories will be copied
# for each test case.
original_repository = os.path.join(original_repository_files, 'repository')
original_keystore = os.path.join(original_repository_files, 'keystore')
original_client = os.path.join(original_repository_files, 'client')
# Save references to the often-needed client repository directories.
# Test cases need these references to access metadata and target files.
self.repository_directory = \
os.path.join(temporary_repository_root, 'repository')
self.keystore_directory = \
os.path.join(temporary_repository_root, 'keystore')
self.client_directory = os.path.join(temporary_repository_root,
'client')
self.client_metadata = os.path.join(self.client_directory,
self.repository_name, 'metadata')
self.client_metadata_current = os.path.join(self.client_metadata,
'current')
self.client_metadata_previous = os.path.join(self.client_metadata,
'previous')
# Copy the original 'repository', 'client', and 'keystore' directories
# to the temporary repository the test cases can use.
shutil.copytree(original_repository, self.repository_directory)
shutil.copytree(original_client, self.client_directory)
shutil.copytree(original_keystore, self.keystore_directory)
# 'path/to/tmp/repository' -> 'localhost:8001/tmp/repository'.
repository_basepath = self.repository_directory[len(os.getcwd()):]
url_prefix = 'http://localhost:' \
+ str(self.server_process_handler.port) + repository_basepath
# Setting 'tuf.settings.repository_directory' with the temporary client
# directory copied from the original repository files.
tuf.settings.repositories_directory = self.client_directory
self.repository_mirrors = {'mirror1': {'url_prefix': url_prefix,
'metadata_path': 'metadata',
'targets_path': 'targets'}}
# Creating a repository instance. The test cases will use this client
# updater to refresh metadata, fetch target files, etc.
self.repository_updater = updater.Updater(self.repository_name,
self.repository_mirrors)
# Metadata role keys are needed by the test cases to make changes to the
# repository (e.g., adding a new target file to 'targets.json' and then
# requesting a refresh()).
self.role_keys = _load_role_keys(self.keystore_directory)
def tearDown(self):
# We are inheriting from custom class.
unittest_toolbox.Modified_TestCase.tearDown(self)
tuf.roledb.clear_roledb(clear_all=True)
tuf.keydb.clear_keydb(clear_all=True)
# Logs stdout and stderr from the sever subprocess.
self.server_process_handler.flush_log()
# UNIT TESTS.
def test_1__init__exceptions(self):
# The client's repository requires a metadata directory (and the 'current'
# and 'previous' sub-directories), and at least the 'root.json' file.
# setUp(), called before each test case, instantiates the required updater
# objects and keys. The needed objects/data is available in
# 'self.repository_updater', 'self.client_directory', etc.
# Test: Invalid arguments.
# Invalid 'updater_name' argument. String expected.
self.assertRaises(securesystemslib.exceptions.FormatError, updater.Updater, 8,
self.repository_mirrors)
# Invalid 'repository_mirrors' argument. 'tuf.formats.MIRRORDICT_SCHEMA'
# expected.
self.assertRaises(securesystemslib.exceptions.FormatError, updater.Updater, updater.Updater, 8)
# 'tuf.client.updater.py' requires that the client's repositories directory
# be configured in 'tuf.settings.py'.
tuf.settings.repositories_directory = None
self.assertRaises(tuf.exceptions.RepositoryError, updater.Updater, 'test_repository1',
self.repository_mirrors)
# Restore 'tuf.settings.repositories_directory' to the original client
# directory.
tuf.settings.repositories_directory = self.client_directory
# Test: repository does not exist
self.assertRaises(tuf.exceptions.MissingLocalRepositoryError, updater.Updater,
'test_non_existing_repository', self.repository_mirrors)
# Test: empty client repository (i.e., no metadata directory).
metadata_backup = self.client_metadata + '.backup'
shutil.move(self.client_metadata, metadata_backup)
self.assertRaises(tuf.exceptions.RepositoryError, updater.Updater, 'test_repository1',
self.repository_mirrors)
# Restore the client's metadata directory.
shutil.move(metadata_backup, self.client_metadata)
# Test: repository with only a '{repository_directory}/metadata' directory.
# (i.e., missing the required 'current' and 'previous' sub-directories).
current_backup = self.client_metadata_current + '.backup'
previous_backup = self.client_metadata_previous + '.backup'
shutil.move(self.client_metadata_current, current_backup)
shutil.move(self.client_metadata_previous, previous_backup)
self.assertRaises(tuf.exceptions.RepositoryError, updater.Updater, 'test_repository1',
self.repository_mirrors)
# Restore the client's previous directory. The required 'current' directory
# is still missing.
shutil.move(previous_backup, self.client_metadata_previous)
# Test: repository with only a '{repository_directory}/metadata/previous'
# directory.
self.assertRaises(tuf.exceptions.RepositoryError, updater.Updater, 'test_repository1',
self.repository_mirrors)
# Restore the client's current directory.
shutil.move(current_backup, self.client_metadata_current)
# Test: repository with a '{repository_directory}/metadata/current'
# directory, but the 'previous' directory is missing.
shutil.move(self.client_metadata_previous, previous_backup)
self.assertRaises(tuf.exceptions.RepositoryError, updater.Updater, 'test_repository1',
self.repository_mirrors)
shutil.move(previous_backup, self.client_metadata_previous)
# Test: repository missing the required 'root.json' file.
client_root_file = os.path.join(self.client_metadata_current, 'root.json')
backup_root_file = client_root_file + '.backup'
shutil.move(client_root_file, backup_root_file)
self.assertRaises(tuf.exceptions.RepositoryError, updater.Updater, 'test_repository1',
self.repository_mirrors)
# Restore the client's 'root.json file.
shutil.move(backup_root_file, client_root_file)
# Test: Normal 'tuf.client.updater.Updater' instantiation.
updater.Updater('test_repository1', self.repository_mirrors)
def test_1__load_metadata_from_file(self):
# Setup
# Get the 'role1.json' filepath. Manually load the role metadata, and
# compare it against the loaded metadata by '_load_metadata_from_file()'.
role1_filepath = \
os.path.join(self.client_metadata_current, 'role1.json')
role1_meta = securesystemslib.util.load_json_file(role1_filepath)
# Load the 'role1.json' file with _load_metadata_from_file, which should
# store the loaded metadata in the 'self.repository_updater.metadata'
# store.
self.assertEqual(len(self.repository_updater.metadata['current']), 4)
self.repository_updater._load_metadata_from_file('current', 'role1')
# Verify that the correct number of metadata objects has been loaded
# (i.e., only the 'root.json' file should have been loaded.
self.assertEqual(len(self.repository_updater.metadata['current']), 5)
# Verify that the content of root metadata is valid.
self.assertEqual(self.repository_updater.metadata['current']['role1'],
role1_meta['signed'])
# Verify that _load_metadata_from_file() doesn't raise an exception for
# improperly formatted metadata, and doesn't load the bad file.
with open(role1_filepath, 'ab') as file_object:
file_object.write(b'bad JSON data')
self.repository_updater._load_metadata_from_file('current', 'role1')
self.assertEqual(len(self.repository_updater.metadata['current']), 5)
# Test if we fail gracefully if we can't deserialize a meta file
self.repository_updater._load_metadata_from_file('current', 'empty_file')
self.assertFalse('empty_file' in self.repository_updater.metadata['current'])
# Test invalid metadata set argument (must be either
# 'current' or 'previous'.)
self.assertRaises(securesystemslib.exceptions.Error,
self.repository_updater._load_metadata_from_file,
'bad_metadata_set', 'role1')
def test_1__rebuild_key_and_role_db(self):
# Setup
root_roleinfo = tuf.roledb.get_roleinfo('root', self.repository_name)
root_metadata = self.repository_updater.metadata['current']['root']
root_threshold = root_metadata['roles']['root']['threshold']
number_of_root_keys = len(root_metadata['keys'])
self.assertEqual(root_roleinfo['threshold'], root_threshold)
# Ensure we add 2 to the number of root keys (actually, the number of root
# keys multiplied by the number of keyid hash algorithms), to include the
# delegated targets key (+1 for its sha512 keyid). The delegated roles of
# 'targets.json' are also loaded when the repository object is
# instantiated.
self.assertEqual(number_of_root_keys + 1, len(tuf.keydb._keydb_dict[self.repository_name]))
# Test: normal case.
self.repository_updater._rebuild_key_and_role_db()
root_roleinfo = tuf.roledb.get_roleinfo('root', self.repository_name)
self.assertEqual(root_roleinfo['threshold'], root_threshold)
# _rebuild_key_and_role_db() will only rebuild the keys and roles specified
# in the 'root.json' file, unlike __init__(). Instantiating an updater
# object calls both _rebuild_key_and_role_db() and _import_delegations().
self.assertEqual(number_of_root_keys, len(tuf.keydb._keydb_dict[self.repository_name]))
# Test: properly updated roledb and keydb dicts if the Root role changes.
root_metadata = self.repository_updater.metadata['current']['root']
root_metadata['roles']['root']['threshold'] = 8
root_metadata['keys'].popitem()
self.repository_updater._rebuild_key_and_role_db()
root_roleinfo = tuf.roledb.get_roleinfo('root', self.repository_name)
self.assertEqual(root_roleinfo['threshold'], 8)
self.assertEqual(number_of_root_keys - 1, len(tuf.keydb._keydb_dict[self.repository_name]))
def test_1__update_versioninfo(self):
# Tests
# Verify that the 'self.versioninfo' dictionary is empty (it starts off
# empty and is only populated if _update_versioninfo() is called.
versioninfo_dict = self.repository_updater.versioninfo
self.assertEqual(len(versioninfo_dict), 0)
# Load the versioninfo of the top-level Targets role. This action
# populates the 'self.versioninfo' dictionary.
self.repository_updater._update_versioninfo('targets.json')
self.assertEqual(len(versioninfo_dict), 1)
self.assertTrue(tuf.formats.FILEINFODICT_SCHEMA.matches(versioninfo_dict))
# The Snapshot role stores the version numbers of all the roles available
# on the repository. Load Snapshot to extract Root's version number
# and compare it against the one loaded by 'self.repository_updater'.
snapshot_filepath = os.path.join(self.client_metadata_current, 'snapshot.json')
snapshot_signable = securesystemslib.util.load_json_file(snapshot_filepath)
targets_versioninfo = snapshot_signable['signed']['meta']['targets.json']
# Verify that the manually loaded version number of root.json matches
# the one loaded by the updater object.
self.assertTrue('targets.json' in versioninfo_dict)
self.assertEqual(versioninfo_dict['targets.json'], targets_versioninfo)
# Verify that 'self.versioninfo' is incremented if another role is updated.
self.repository_updater._update_versioninfo('role1.json')
self.assertEqual(len(versioninfo_dict), 2)
# Verify that 'self.versioninfo' is incremented if a non-existent role is
# requested, and has its versioninfo entry set to 'None'.
self.repository_updater._update_versioninfo('bad_role.json')
self.assertEqual(len(versioninfo_dict), 3)
self.assertEqual(versioninfo_dict['bad_role.json'], None)
# Verify that the versioninfo specified in Timestamp is used if the Snapshot
# role hasn't been downloaded yet.
del self.repository_updater.metadata['current']['snapshot']
#self.assertRaises(self.repository_updater._update_versioninfo('snapshot.json'))
self.repository_updater._update_versioninfo('snapshot.json')
self.assertEqual(versioninfo_dict['snapshot.json']['version'], 1)
def test_1__refresh_must_not_count_duplicate_keyids_towards_threshold(self):
# Update root threshold on the server repository and sign twice with 1 key
repository = repo_tool.load_repository(self.repository_directory)
repository.root.threshold = 2
repository.root.load_signing_key(self.role_keys['root']['private'])
storage_backend = securesystemslib.storage.FilesystemBackend()
# The client uses the threshold from the previous root file to verify the
# new root. Thus we need to make two updates so that the threshold used for
# verification becomes 2. I.e. we bump the version, sign twice with the
# same key and write to disk '2.root.json' and '3.root.json'.
for version in [2, 3]:
repository.root.version = version
info = tuf.roledb.get_roleinfo("root")
metadata = repo_lib.generate_root_metadata(
info["version"], info["expires"], False)
signed_metadata = repo_lib.sign_metadata(
metadata, info["keyids"], "root.json", "default")
signed_metadata["signatures"].append(signed_metadata["signatures"][0])
live_root_path = os.path.join(
self.repository_directory, "metadata", "root.json")
# Bypass server side verification in 'write' or 'writeall', which would
# catch the unmet threshold.
# We also skip writing to 'metadata.staged' and copying to 'metadata' and
# instead write directly to 'metadata'
repo_lib.write_metadata_file(signed_metadata, live_root_path,
info["version"], True, storage_backend)
# Update from current '1.root.json' to '3.root.json' on client and assert
# raise of 'BadSignatureError' (caused by unmet signature threshold).
try:
self.repository_updater.refresh()
except tuf.exceptions.NoWorkingMirrorError as e:
mirror_errors = list(e.mirror_errors.values())
self.assertTrue(len(mirror_errors) == 1)
self.assertTrue(
isinstance(mirror_errors[0],
securesystemslib.exceptions.BadSignatureError))
self.assertEqual(
str(mirror_errors[0]),
repr("root") + " metadata has bad signature.")
else:
self.fail(
"Expected a NoWorkingMirrorError composed of one BadSignatureError")
def test_1__update_fileinfo(self):
# Tests
# Verify that the 'self.fileinfo' dictionary is empty (its starts off empty
# and is only populated if _update_fileinfo() is called.
fileinfo_dict = self.repository_updater.fileinfo
self.assertEqual(len(fileinfo_dict), 0)
# Load the fileinfo of the top-level root role. This populates the
# 'self.fileinfo' dictionary.
self.repository_updater._update_fileinfo('root.json')
self.assertEqual(len(fileinfo_dict), 1)
self.assertTrue(tuf.formats.FILEDICT_SCHEMA.matches(fileinfo_dict))
root_filepath = os.path.join(self.client_metadata_current, 'root.json')
length, hashes = securesystemslib.util.get_file_details(root_filepath)
root_fileinfo = tuf.formats.make_targets_fileinfo(length, hashes)
self.assertTrue('root.json' in fileinfo_dict)
self.assertEqual(fileinfo_dict['root.json'], root_fileinfo)
# Verify that 'self.fileinfo' is incremented if another role is updated.
self.repository_updater._update_fileinfo('targets.json')
self.assertEqual(len(fileinfo_dict), 2)
# Verify that 'self.fileinfo' is inremented if a non-existent role is
# requested, and has its fileinfo entry set to 'None'.
self.repository_updater._update_fileinfo('bad_role.json')
self.assertEqual(len(fileinfo_dict), 3)
self.assertEqual(fileinfo_dict['bad_role.json'], None)
def test_2__fileinfo_has_changed(self):
# Verify that the method returns 'False' if file info was not changed.
root_filepath = os.path.join(self.client_metadata_current, 'root.json')
length, hashes = securesystemslib.util.get_file_details(root_filepath)
root_fileinfo = tuf.formats.make_targets_fileinfo(length, hashes)
self.assertFalse(self.repository_updater._fileinfo_has_changed('root.json',
root_fileinfo))
# Verify that the method returns 'True' if length or hashes were changed.
new_length = 8
new_root_fileinfo = tuf.formats.make_targets_fileinfo(new_length, hashes)
self.assertTrue(self.repository_updater._fileinfo_has_changed('root.json',
new_root_fileinfo))
# Hashes were changed.
new_hashes = {'sha256': self.random_string()}
new_root_fileinfo = tuf.formats.make_targets_fileinfo(length, new_hashes)
self.assertTrue(self.repository_updater._fileinfo_has_changed('root.json',
new_root_fileinfo))
# Verify that _fileinfo_has_changed() returns True if no fileinfo (or set
# to None) exists for some role.
self.assertTrue(self.repository_updater._fileinfo_has_changed('bad.json',
new_root_fileinfo))
saved_fileinfo = self.repository_updater.fileinfo['root.json']
self.repository_updater.fileinfo['root.json'] = None
self.assertTrue(self.repository_updater._fileinfo_has_changed('root.json',
new_root_fileinfo))
self.repository_updater.fileinfo['root.json'] = saved_fileinfo
new_root_fileinfo['hashes']['sha666'] = '666'
self.repository_updater._fileinfo_has_changed('root.json',
new_root_fileinfo)
def test_2__import_delegations(self):
# Setup.
# In order to test '_import_delegations' the parent of the delegation
# has to be in Repository.metadata['current'], but it has to be inserted
# there without using '_load_metadata_from_file()' since it calls
# '_import_delegations()'.
repository_name = self.repository_updater.repository_name
tuf.keydb.clear_keydb(repository_name)
tuf.roledb.clear_roledb(repository_name)
self.assertEqual(len(tuf.roledb._roledb_dict[repository_name]), 0)
self.assertEqual(len(tuf.keydb._keydb_dict[repository_name]), 0)
self.repository_updater._rebuild_key_and_role_db()
self.assertEqual(len(tuf.roledb._roledb_dict[repository_name]), 4)
# Take into account the number of keyids algorithms supported by default,
# which this test condition expects to be two (sha256 and sha512).
self.assertEqual(4, len(tuf.keydb._keydb_dict[repository_name]))
# Test: pass a role without delegations.
self.repository_updater._import_delegations('root')
# Verify that there was no change to the roledb and keydb dictionaries by
# checking the number of elements in the dictionaries.
self.assertEqual(len(tuf.roledb._roledb_dict[repository_name]), 4)
# Take into account the number of keyid hash algorithms, which this
# test condition expects to be one
self.assertEqual(len(tuf.keydb._keydb_dict[repository_name]), 4)
# Test: normal case, first level delegation.
self.repository_updater._import_delegations('targets')
self.assertEqual(len(tuf.roledb._roledb_dict[repository_name]), 5)
# The number of root keys (times the number of key hash algorithms) +
# delegation's key (+1 for its sha512 keyid).
self.assertEqual(len(tuf.keydb._keydb_dict[repository_name]), 4 + 1)
# Verify that roledb dictionary was added.
self.assertTrue('role1' in tuf.roledb._roledb_dict[repository_name])
# Verify that keydb dictionary was updated.
role1_signable = \
securesystemslib.util.load_json_file(os.path.join(self.client_metadata_current,
'role1.json'))
keyids = []
for signature in role1_signable['signatures']:
keyids.append(signature['keyid'])
for keyid in keyids:
self.assertTrue(keyid in tuf.keydb._keydb_dict[repository_name])
# Verify that _import_delegations() ignores invalid keytypes in the 'keys'
# field of parent role's 'delegations'.
existing_keyid = keyids[0]
self.repository_updater.metadata['current']['targets']\
['delegations']['keys'][existing_keyid]['keytype'] = 'bad_keytype'
self.repository_updater._import_delegations('targets')
# Restore the keytype of 'existing_keyid'.
self.repository_updater.metadata['current']['targets']\
['delegations']['keys'][existing_keyid]['keytype'] = 'ed25519'
# Verify that _import_delegations() raises an exception if one of the
# delegated keys is malformed.
valid_keyval = self.repository_updater.metadata['current']['targets']\
['delegations']['keys'][existing_keyid]['keyval']
self.repository_updater.metadata['current']['targets']\
['delegations']['keys'][existing_keyid]['keyval'] = 1
self.assertRaises(securesystemslib.exceptions.FormatError, self.repository_updater._import_delegations, 'targets')
self.repository_updater.metadata['current']['targets']\
['delegations']['keys'][existing_keyid]['keyval'] = valid_keyval
# Verify that _import_delegations() raises an exception if one of the
# delegated roles is malformed.
self.repository_updater.metadata['current']['targets']\
['delegations']['roles'][0]['name'] = 1
self.assertRaises(securesystemslib.exceptions.FormatError, self.repository_updater._import_delegations, 'targets')
def test_2__versioninfo_has_been_updated(self):
# Verify that the method returns 'False' if a versioninfo was not changed.
snapshot_filepath = os.path.join(self.client_metadata_current, 'snapshot.json')
snapshot_signable = securesystemslib.util.load_json_file(snapshot_filepath)
targets_versioninfo = snapshot_signable['signed']['meta']['targets.json']
self.assertFalse(self.repository_updater._versioninfo_has_been_updated('targets.json',
targets_versioninfo))
# Verify that the method returns 'True' if Root's version number changes.
targets_versioninfo['version'] = 8
self.assertTrue(self.repository_updater._versioninfo_has_been_updated('targets.json',
targets_versioninfo))
def test_2__move_current_to_previous(self):
# Test case will consist of removing a metadata file from client's
# '{client_repository}/metadata/previous' directory, executing the method
# and then verifying that the 'previous' directory contains the snapshot
# file.
previous_snapshot_filepath = os.path.join(self.client_metadata_previous,
'snapshot.json')
os.remove(previous_snapshot_filepath)
self.assertFalse(os.path.exists(previous_snapshot_filepath))
# Verify that the current 'snapshot.json' is moved to the previous directory.
self.repository_updater._move_current_to_previous('snapshot')
self.assertTrue(os.path.exists(previous_snapshot_filepath))
def test_2__delete_metadata(self):
# This test will verify that 'root' metadata is never deleted. When a role
# is deleted verify that the file is not present in the
# 'self.repository_updater.metadata' dictionary.
self.repository_updater._delete_metadata('root')
self.assertTrue('root' in self.repository_updater.metadata['current'])
self.repository_updater._delete_metadata('timestamp')
self.assertFalse('timestamp' in self.repository_updater.metadata['current'])
def test_2__ensure_not_expired(self):
# This test condition will verify that nothing is raised when a metadata
# file has a future expiration date.
root_metadata = self.repository_updater.metadata['current']['root']
self.repository_updater._ensure_not_expired(root_metadata, 'root')
# 'tuf.exceptions.ExpiredMetadataError' should be raised in this next test condition,
# because the expiration_date has expired by 10 seconds.
expires = tuf.formats.unix_timestamp_to_datetime(int(time.time() - 10))
expires = expires.isoformat() + 'Z'
root_metadata['expires'] = expires
# Ensure the 'expires' value of the root file is valid by checking the
# the formats of the 'root.json' object.
self.assertTrue(tuf.formats.ROOT_SCHEMA.matches(root_metadata))
self.assertRaises(tuf.exceptions.ExpiredMetadataError,
self.repository_updater._ensure_not_expired,
root_metadata, 'root')
def test_3__update_metadata(self):
# Setup
# _update_metadata() downloads, verifies, and installs the specified
# metadata role. Remove knowledge of currently installed metadata and
# verify that they are re-installed after calling _update_metadata().
# This is the default metadata that we would create for the timestamp role,
# because it has no signed metadata for itself.
DEFAULT_TIMESTAMP_FILELENGTH = tuf.settings.DEFAULT_TIMESTAMP_REQUIRED_LENGTH
# This is the upper bound length for Targets metadata.
DEFAULT_TARGETS_FILELENGTH = tuf.settings.DEFAULT_TARGETS_REQUIRED_LENGTH
# Save the versioninfo of 'targets.json,' needed later when re-installing
# with _update_metadata().
targets_versioninfo = \
self.repository_updater.metadata['current']['snapshot']['meta']\
['targets.json']
# Remove the currently installed metadata from the store and disk. Verify
# that the metadata dictionary is re-populated after calling
# _update_metadata().
del self.repository_updater.metadata['current']['timestamp']
del self.repository_updater.metadata['current']['targets']
timestamp_filepath = \
os.path.join(self.client_metadata_current, 'timestamp.json')
targets_filepath = os.path.join(self.client_metadata_current, 'targets.json')
root_filepath = os.path.join(self.client_metadata_current, 'root.json')
os.remove(timestamp_filepath)
os.remove(targets_filepath)
# Test: normal case.
# Verify 'timestamp.json' is properly installed.
self.assertFalse('timestamp' in self.repository_updater.metadata)
logger.info('\nroleinfo: ' + repr(tuf.roledb.get_rolenames(self.repository_name)))
self.repository_updater._update_metadata('timestamp',
DEFAULT_TIMESTAMP_FILELENGTH)
self.assertTrue('timestamp' in self.repository_updater.metadata['current'])
os.path.exists(timestamp_filepath)
# Verify 'targets.json' is properly installed.
self.assertFalse('targets' in self.repository_updater.metadata['current'])
self.repository_updater._update_metadata('targets',
DEFAULT_TARGETS_FILELENGTH,
targets_versioninfo['version'])
self.assertTrue('targets' in self.repository_updater.metadata['current'])
targets_signable = securesystemslib.util.load_json_file(targets_filepath)
loaded_targets_version = targets_signable['signed']['version']
self.assertEqual(targets_versioninfo['version'], loaded_targets_version)
# Test: Invalid / untrusted version numbers.
# Invalid version number for 'targets.json'.
self.assertRaises(tuf.exceptions.NoWorkingMirrorError,
self.repository_updater._update_metadata,
'targets', DEFAULT_TARGETS_FILELENGTH, 88)
# Verify that the specific exception raised is correct for the previous
# case.
try:
self.repository_updater._update_metadata('targets',
DEFAULT_TARGETS_FILELENGTH, 88)
except tuf.exceptions.NoWorkingMirrorError as e:
for mirror_error in six.itervalues(e.mirror_errors):
assert isinstance(mirror_error, tuf.exceptions.BadVersionNumberError)
else:
self.fail(
'Expected a NoWorkingMirrorError composed of BadVersionNumberErrors')
# Verify that the specific exception raised is correct for the previous
# case. The version number is checked, so the specific error in
# this case should be 'tuf.exceptions.BadVersionNumberError'.
try:
self.repository_updater._update_metadata('targets',
DEFAULT_TARGETS_FILELENGTH,
88)
except tuf.exceptions.NoWorkingMirrorError as e:
for mirror_error in six.itervalues(e.mirror_errors):
assert isinstance(mirror_error, tuf.exceptions.BadVersionNumberError)
else:
self.fail(
'Expected a NoWorkingMirrorError composed of BadVersionNumberErrors')
def test_3__get_metadata_file(self):
'''
This test focuses on making sure that the updater rejects unknown or
badly-formatted TUF specification version numbers....
'''
# Make note of the correct supported TUF specification version.
correct_specification_version = tuf.SPECIFICATION_VERSION
# Change it long enough to write new metadata.
tuf.SPECIFICATION_VERSION = '0.9.0'
repository = repo_tool.load_repository(self.repository_directory)
repository.timestamp.load_signing_key(self.role_keys['timestamp']['private'])
repository.writeall()
# Move the staged metadata to the "live" metadata.
shutil.rmtree(os.path.join(self.repository_directory, 'metadata'))
shutil.copytree(os.path.join(self.repository_directory, 'metadata.staged'),
os.path.join(self.repository_directory, 'metadata'))
# Change the supported TUF specification version back to what it should be
# so that we can parse the metadata and see that the spec version in the
# metadata does not match the code's expected spec version.
tuf.SPECIFICATION_VERSION = correct_specification_version
upperbound_filelength = tuf.settings.DEFAULT_TIMESTAMP_REQUIRED_LENGTH
try:
self.repository_updater._get_metadata_file('timestamp', 'timestamp.json',
upperbound_filelength, 1)
except tuf.exceptions.NoWorkingMirrorError as e:
# Note that this test provides a piece of metadata which would fail to
# be accepted -- with a different error -- if the specification version
# number were not a problem.
for mirror_error in six.itervalues(e.mirror_errors):
assert isinstance(
mirror_error, tuf.exceptions.UnsupportedSpecificationError)
else:
self.fail(
'Expected a failure to verify metadata when the metadata had a '
'specification version number that was unexpected. '
'No error was raised.')
def test_3__update_metadata_if_changed(self):
# Setup.
# The client repository is initially loaded with only four top-level roles.
# Verify that the metadata store contains the metadata of only these four
# roles before updating the metadata of 'targets.json'.
self.assertEqual(len(self.repository_updater.metadata['current']), 4)
self.assertTrue('targets' in self.repository_updater.metadata['current'])
targets_path = os.path.join(self.client_metadata_current, 'targets.json')
self.assertTrue(os.path.exists(targets_path))
self.assertEqual(self.repository_updater.metadata['current']['targets']['version'], 1)
# Test: normal case. Update 'targets.json'. The version number should not
# change.
self.repository_updater._update_metadata_if_changed('targets')
# Verify the current version of 'targets.json' has not changed.
self.assertEqual(self.repository_updater.metadata['current']['targets']['version'], 1)
# Modify one target file on the remote repository.
repository = repo_tool.load_repository(self.repository_directory)
target3 = 'file3.txt'
repository.targets.add_target(target3)
repository.root.version = repository.root.version + 1
repository.root.load_signing_key(self.role_keys['root']['private'])
repository.targets.load_signing_key(self.role_keys['targets']['private'])
repository.snapshot.load_signing_key(self.role_keys['snapshot']['private'])
repository.timestamp.load_signing_key(self.role_keys['timestamp']['private'])
repository.writeall()
# Move the staged metadata to the "live" metadata.
shutil.rmtree(os.path.join(self.repository_directory, 'metadata'))
shutil.copytree(os.path.join(self.repository_directory, 'metadata.staged'),
os.path.join(self.repository_directory, 'metadata'))
# Update 'targets.json' and verify that the client's current 'targets.json'
# has been updated. 'timestamp' and 'snapshot' must be manually updated
# so that new 'targets' can be recognized.
DEFAULT_TIMESTAMP_FILELENGTH = tuf.settings.DEFAULT_TIMESTAMP_REQUIRED_LENGTH
self.repository_updater._update_metadata('timestamp', DEFAULT_TIMESTAMP_FILELENGTH)
self.repository_updater._update_metadata_if_changed('snapshot', 'timestamp')
self.repository_updater._update_metadata_if_changed('targets')
targets_path = os.path.join(self.client_metadata_current, 'targets.json')
self.assertTrue(os.path.exists(targets_path))
self.assertTrue(self.repository_updater.metadata['current']['targets'])
self.assertEqual(self.repository_updater.metadata['current']['targets']['version'], 2)
# Test for an invalid 'referenced_metadata' argument.
self.assertRaises(tuf.exceptions.RepositoryError,
self.repository_updater._update_metadata_if_changed, 'snapshot', 'bad_role')
def test_3__targets_of_role(self):
# Setup.
# Extract the list of targets from 'targets.json', to be compared to what
# is returned by _targets_of_role('targets').
targets_in_metadata = \
self.repository_updater.metadata['current']['targets']['targets']
# Test: normal case.
targetinfos_list = self.repository_updater._targets_of_role('targets')
# Verify that the list of targets was returned, and that it contains valid
# target files.
self.assertTrue(tuf.formats.TARGETINFOS_SCHEMA.matches(targetinfos_list))
for targetinfo in targetinfos_list:
self.assertTrue((targetinfo['filepath'], targetinfo['fileinfo']) in six.iteritems(targets_in_metadata))
def test_4_refresh(self):
# This unit test is based on adding an extra target file to the
# server and rebuilding all server-side metadata. All top-level metadata
# should be updated when the client calls refresh().
# First verify that an expired root metadata is updated.
expired_date = '1960-01-01T12:00:00Z'
self.repository_updater.metadata['current']['root']['expires'] = expired_date
self.repository_updater.refresh()
# Second, verify that expired root metadata is not updated if
# 'unsafely_update_root_if_necessary' is explicitly set to 'False'.
expired_date = '1960-01-01T12:00:00Z'
self.repository_updater.metadata['current']['root']['expires'] = expired_date
self.assertRaises(tuf.exceptions.ExpiredMetadataError,
self.repository_updater.refresh,
unsafely_update_root_if_necessary=False)
repository = repo_tool.load_repository(self.repository_directory)
target3 = 'file3.txt'
repository.targets.add_target(target3)
repository.targets.load_signing_key(self.role_keys['targets']['private'])
repository.snapshot.load_signing_key(self.role_keys['snapshot']['private'])
repository.timestamp.load_signing_key(self.role_keys['timestamp']['private'])
repository.writeall()
# Move the staged metadata to the "live" metadata.
shutil.rmtree(os.path.join(self.repository_directory, 'metadata'))
shutil.copytree(os.path.join(self.repository_directory, 'metadata.staged'),
os.path.join(self.repository_directory, 'metadata'))
# Reference 'self.Repository.metadata['current']['targets']'. Ensure
# 'target3' is not already specified.
targets_metadata = self.repository_updater.metadata['current']['targets']
self.assertFalse(target3 in targets_metadata['targets'])
# Verify the expected version numbers of the roles to be modified.
self.assertEqual(self.repository_updater.metadata['current']['targets']\
['version'], 1)
self.assertEqual(self.repository_updater.metadata['current']['snapshot']\
['version'], 1)
self.assertEqual(self.repository_updater.metadata['current']['timestamp']\
['version'], 1)
# Test: normal case. 'targes.json' should now specify 'target3', and the
# following top-level metadata should have also been updated:
# 'snapshot.json' and 'timestamp.json'.
self.repository_updater.refresh()
# Verify that the client's metadata was updated.
targets_metadata = self.repository_updater.metadata['current']['targets']
self.assertTrue(target3 in targets_metadata['targets'])
# Verify the expected version numbers of the updated roles.
self.assertEqual(self.repository_updater.metadata['current']['targets']\
['version'], 2)
self.assertEqual(self.repository_updater.metadata['current']['snapshot']\
['version'], 2)
self.assertEqual(self.repository_updater.metadata['current']['timestamp']\
['version'], 2)
def test_4__refresh_targets_metadata(self):
# Setup.
# It is assumed that the client repository has only loaded the top-level
# metadata. Refresh the 'targets.json' metadata, including all delegated
# roles (i.e., the client should add the missing 'role1.json' metadata.
self.assertEqual(len(self.repository_updater.metadata['current']), 4)
# Test: normal case.
self.repository_updater._refresh_targets_metadata(refresh_all_delegated_roles=True)
# Verify that client's metadata files were refreshed successfully.
self.assertEqual(len(self.repository_updater.metadata['current']), 6)
# Test for non-existing rolename.
self.repository_updater._refresh_targets_metadata('bad_rolename',
refresh_all_delegated_roles=False)
# Test that non-json metadata in Snapshot is ignored.
self.repository_updater.metadata['current']['snapshot']['meta']['bad_role.xml'] = {}
self.repository_updater._refresh_targets_metadata(refresh_all_delegated_roles=True)
def test_5_all_targets(self):
# Setup
# As with '_refresh_targets_metadata()',