Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client refactor: review file object handling #1318

Closed
jku opened this issue Mar 18, 2021 · 2 comments
Closed

client refactor: review file object handling #1318

jku opened this issue Mar 18, 2021 · 2 comments
Assignees
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)

Comments

@jku
Copy link
Member

jku commented Mar 18, 2021

There's a lot more manual file closing (temp_obj.close()) than I'd like and I can already see bugs: the same file object gets closed multiple times on some exceptions.

Let's do a comprehensive review and aim to A) get rid of as many manual close()s as we can and B) make the remaining ones more obviously correct

@jku jku added the experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch) label Mar 18, 2021
@jku
Copy link
Member Author

jku commented Apr 7, 2021

I'll take this as an excuse to get more familiar with the code

@jku
Copy link
Member Author

jku commented May 17, 2021

This one is done already: file object handling has been vastly reduced in the experimental client

@jku jku closed this as completed May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)
Projects
None yet
Development

No branches or pull requests

2 participants