Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger SSL verification and HTTP redirection #50

Closed
trishankkarthik opened this issue Mar 19, 2013 · 6 comments
Closed

Stronger SSL verification and HTTP redirection #50

trishankkarthik opened this issue Mar 19, 2013 · 6 comments
Assignees

Comments

@trishankkarthik
Copy link
Contributor

tuf.download needs stronger SSL verification (i.e. use stronger SSL ciphers and protocol versions).

@ghost ghost assigned trishankkarthik Mar 19, 2013
@trishankkarthik
Copy link
Contributor Author

Among other things, we have to consider whether or not we want to allow HTTP redirection.

@trishankkarthik
Copy link
Contributor Author

See discussion here.

@trishankkarthik
Copy link
Contributor Author

Just a side note: here is an Apple SSL bug from Feb 22 2014.

@lukpueh
Copy link
Member

lukpueh commented Sep 24, 2019

@trishankatdatadog, is this issue still relevant? Judging from the mailing list discussion you linked above some of the problems are concerns of the server configuration and not TUF.

Also, in the meantime, we switched to requests, which according to howsmyssl.com fares quite alright (see dump below).

Regarding redirects, they are on per default in requests, and we don't change that in tuf.downloads. Is there a reason why we should?

I suggest to close here...

>>> import requests
>>> from pprint import pprint
>>> pprint(requests.get("https://www.howsmyssl.com/a/check").json())
{'able_to_detect_n_minus_one_splitting': False,
 'beast_vuln': False,
 'ephemeral_keys_supported': True,
 'insecure_cipher_suites': {},
 'rating': 'Probably Okay',
 'session_ticket_supported': True,
 'tls_compression_supported': False,
 'tls_version': 'TLS 1.2',
 'unknown_cipher_suite_supported': False,
 'given_cipher_suites': ['TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384',
                         'TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384',
                         'TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256',
                         'TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256',
                         'TLS_DHE_RSA_WITH_AES_256_GCM_SHA384',
                         'TLS_DHE_RSA_WITH_AES_128_GCM_SHA256',
                         'TLS_ECDH_RSA_WITH_AES_256_GCM_SHA384',
                         'TLS_ECDH_ECDSA_WITH_AES_256_GCM_SHA384',
                         'TLS_ECDH_RSA_WITH_AES_128_GCM_SHA256',
                         'TLS_ECDH_ECDSA_WITH_AES_128_GCM_SHA256',
                         'TLS_DH_DSS_WITH_AES_256_GCM_SHA384',
                         'TLS_DH_RSA_WITH_AES_256_GCM_SHA384',
                         'TLS_DH_DSS_WITH_AES_128_GCM_SHA256',
                         'TLS_DH_RSA_WITH_AES_128_GCM_SHA256',
                         'TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384',
                         'TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384',
                         'TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA',
                         'TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA',
                         'TLS_ECDH_RSA_WITH_AES_256_CBC_SHA384',
                         'TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA384',
                         'TLS_ECDH_RSA_WITH_AES_256_CBC_SHA',
                         'TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA',
                         'TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256',
                         'TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256',
                         'TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA',
                         'TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA',
                         'TLS_ECDH_RSA_WITH_AES_128_CBC_SHA256',
                         'TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA256',
                         'TLS_ECDH_RSA_WITH_AES_128_CBC_SHA',
                         'TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA',
                         'TLS_DHE_RSA_WITH_AES_256_CBC_SHA256',
                         'TLS_DH_RSA_WITH_AES_256_CBC_SHA256',
                         'TLS_DH_DSS_WITH_AES_256_CBC_SHA256',
                         'TLS_DHE_RSA_WITH_AES_256_CBC_SHA',
                         'TLS_DH_RSA_WITH_AES_256_CBC_SHA',
                         'TLS_DH_DSS_WITH_AES_256_CBC_SHA',
                         'TLS_DHE_RSA_WITH_AES_128_CBC_SHA256',
                         'TLS_DH_RSA_WITH_AES_128_CBC_SHA256',
                         'TLS_DH_DSS_WITH_AES_128_CBC_SHA256',
                         'TLS_DHE_RSA_WITH_AES_128_CBC_SHA',
                         'TLS_DH_RSA_WITH_AES_128_CBC_SHA',
                         'TLS_DH_DSS_WITH_AES_128_CBC_SHA',
                         'TLS_RSA_WITH_AES_256_GCM_SHA384',
                         'TLS_RSA_WITH_AES_128_GCM_SHA256',
                         'TLS_RSA_WITH_AES_256_CBC_SHA256',
                         'TLS_RSA_WITH_AES_256_CBC_SHA',
                         'TLS_RSA_WITH_AES_128_CBC_SHA256',
                         'TLS_RSA_WITH_AES_128_CBC_SHA',
                         'TLS_EMPTY_RENEGOTIATION_INFO_SCSV']}

@trishankatdatadog
Copy link
Member

Looks OK to me. @JustinCappos any reservations?

@JustinCappos
Copy link
Member

JustinCappos commented Sep 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants