tests: Use current python interpreter for sub tests #1337
Conversation
Can be useful to run tests using distro runtimes, (like python3 on Debian). Relate-to: theupdateframework#263 Forwarded: theupdateframework#1337 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
c859411
to
752e9f2
Compare
Can be useful to run tests using distro runtimes, (like python3 on Debian). Relate-to: theupdateframework#263 Origin: https://salsa.debian.org/rzr/python-tuf/-/tree/debian/review/master Forwarded: theupdateframework#1337 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
752e9f2
to
baf3aad
Compare
|
Looks correct to me. The CI failures are some unrelated Windows BS as far as I can tell. |
|
Hmm, re-running the tests still gives multiple failures here but other PRs are green... I don't think there's anything wrong with this PR but maybe this actually does end up changing the executable used on CI and this triggers the issues? we could wait until we can test this with some test fixes from #1344... |
|
I assumed those were sporadic failures. Since it was on windows and I was unable to reproduce, I didn't look too much in details, |
|
test processes still seem to have open files in the directory we try to remove on test cleanup. Windows is very picky about that -- but unfortunately not reliably so. This change seems to have made it more reliable, or alternatively something changed in github end in the last day. The failure I looked at does look like a bug in our tests: I'll try fixing that on monday and we'll see how it affects this. |
Can be useful to run tests using distro runtimes, (like python3 on Debian). Relate-to: theupdateframework#263 Origin: https://salsa.debian.org/rzr/python-tuf/-/tree/debian/review/master Forwarded: theupdateframework#1337 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
baf3aad
to
79199ff
Compare
Can be useful to run tests using distro runtimes, (like python3 on Debian). Relate-to: theupdateframework#263 Origin: https://salsa.debian.org/rzr/python-tuf/-/tree/debian/review/master Forwarded: theupdateframework#1337 Signed-off-by: Philippe Coval <rzr@users.sf.net>
|
Would you mind rebasing this so we see test results with the hopefully fixed tests? |
Can be useful to run tests using distro runtimes, (like python3 on Debian). Relate-to: theupdateframework#263 Origin: https://salsa.debian.org/rzr/python-tuf/-/tree/debian/review/master Forwarded: theupdateframework#1337 Signed-off-by: Philippe Coval <rzr@users.sf.net>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
79199ff
to
f00f893
Compare
|
Thanks! |
Applied-Upstream: theupdateframework#1337 Relate-to: theupdateframework#263
Applied-Upstream: theupdateframework#1337 Relate-to: theupdateframework#263 Signed-off-by: Philippe Coval <rzr@users.sf.net>
Applied-Upstream: theupdateframework#1337 Relate-to: theupdateframework#263 Signed-off-by: Philippe Coval <rzr@users.sf.net>
Can be useful to run tests using distro runtimes,
(like python3 on Debian).
Relate-to: #263
Signed-off-by: Philippe Coval rzr@users.sf.net
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes #
Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following
requirements: