Document ADR 0008 about unrecognized fields #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshuagl I addressed your comments and amend the commit so it can be ready to be merged. PS: I had to force-push a couple of times to fix some formatting issues. |
MVrachev
force-pushed
the
adr8
branch
2 times, most recently
from
73fa130
to
6a68dfb
Compare
joshuagl
reviewed
Apr 13, 2021
Even though, this ADR documents something already implied in the TUF spec in [document formats](https://theupdateframework.github.io/specification/latest/#document-formats) it seems better to document this decision clearly so that it could be referenced and give an explanation why someone can load a metadata file with additional unrecognized fields. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
|
I am not sure why, but we have a CI failure again on Windows |
|
Not at all, this is tox calling pip and pip failing to download "typed-ast" in some fantastic way... |
|
For reference: the CI failure seems like a pypi problem (made worse by our decision to use pre-release build tooling so downloading more often). Disappeared on re-run, I'm not filing any issues on that. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes #1266
Description of the changes being introduced by the pull request:
Even though, this ADR documents something already implied in the TUF
spec in document formats
it seems better to document this decision clearly so that it could be
referenced and give an explanation why someone can load a metadata file
with additional unrecognized fields.
Signed-off-by: Martin Vrachev mvrachev@vmware.com
Please verify and check that the pull request fulfills the following
requirements: