Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos download no longer working #76

Closed
ghnp5 opened this issue Dec 7, 2022 · 5 comments
Closed

Videos download no longer working #76

ghnp5 opened this issue Dec 7, 2022 · 5 comments

Comments

@ghnp5
Copy link

ghnp5 commented Dec 7, 2022

Since several days ago, videos on Posts no longer download (still works in Stories).

Changing hasAttribute("loop") to hasAttribute("playsinline") resolves the issue.

I'd like to suggest again that you could make the original code public, to make it easier for the community to fix these issues earlier :)
Looking at this obfuscated/minified code makes things a lot harder to debug and resolve.

Thanks!

@slomomojo
Copy link

See the "Discussions" tab for the reason behind the code removal. You can request access to the private repo.

@ghnp5
Copy link
Author

ghnp5 commented Dec 9, 2022

Aah, I've just read it, and understand. Thanks for being transparent!

If you could invite me to that repo, that would be very great, please! I definitely don't plan to create a clone!
Just want to keep getting this working whenever it gets broken, haha 😊

Cheers.

@theus
Copy link
Owner

theus commented Dec 12, 2022

Hey @ghnp5 , happy that you want to help. I'll invite you to the private repo 👌

@ghnp5
Copy link
Author

ghnp5 commented Dec 12, 2022

Thanks much! I've a fix here - https://github.com/theus/instantgram-core/pull/5

You may want to do the housekeeping bit of updating the version number, build and release :)

Cheers!!

@theus
Copy link
Owner

theus commented Dec 12, 2022

Thanks @ghnp5, I'll try to build and release that today yet!

@theus theus closed this as completed in 48e53ed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants