'Add all to palette' in 'Brightness/Darkness' produces disordered results

[thezbyg]

Original issue 38 created by thezbyg on 2011-05-29T00:07:37.000Z:

I was writing a detailed article on how to use GPick (which you are welcome to use here on the wiki, BTW, when it's done.), when
I discovered this bug.

Most logical groups of colors are added in an orderly way. Brightness-Darkness's colors, OTOH, are added in a consistent, but badly ordered way, IMO.

954
853
752
651

^^ text depiction of the layout of the brightness-darkness 'window', in the order that makes sense to add the colors IMO. 5 is the base color, 1-4 are darker versions, 6-9 are lighter. This would be consistent with the 'Variations' and 'Color scheme' 'windows' in terms of the color ordering it produces.

The order that they actually get added to the palette in currently looks like this:

846
943
241
745

(4 being the base color here.)

Which doesn't seem to have any sensible order to it at all.

[thezbyg]

Comment #1 originally posted by thezbyg on 2011-05-29T00:18:02.000Z:

I'm pretty sure lua table hashing is the culprit. working on a fix now.

[thezbyg]

Comment #2 originally posted by thezbyg on 2011-05-29T01:46:27.000Z:

Fixed. Patch attached.

[thezbyg]

Comment #3 originally posted by thezbyg on 2011-05-29T08:49:33.000Z:

Thanks for the patch, I committed a fix in revision 8523b7083ed6

Good luck with the article, any kind of documentation is highly valuable

[thezbyg]

Comment #4 originally posted by thezbyg on 2011-05-29T09:31:10.000Z:

Hah, obviously you spotted something I missed -- the way I initially tried to fix this bug looked just like your approach, but whenever I used ipairs(), 'add all to palette' would do nothing :)