Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Positive (27) doesn't cancel out Image: Negative (7) correctly #19

Closed
normanr opened this issue Aug 30, 2016 · 2 comments
Closed

Comments

@normanr
Copy link

normanr commented Aug 30, 2016

I've trying to use aha with output generated by:

file1:
this is a test

file2:
this is also a test

diff -u file1 file2 | diff-highlight | aha > diff.html

This results in the end of line 1 (and line 2) being a weird background color. I expect a white background (no background color overridden), but it's gray instead.

It looks like the ^[27m isn't cancelling the ^[7m correctly.

diff-highlight can be found at git/contrib/diff-highlight

@theZiz
Copy link
Owner

theZiz commented Sep 1, 2016

Well, I just found a big "//TODO" in my code around the invertation code.

I will fix this. ;)

On Tue, 30 Aug 2016 15:57:57 -0700
Norman Rasmussen notifications@github.com wrote:

I've trying to use aha with output generated by:

file1:
this is a test

file2:
this is also a test

diff -u file1 file2 | diff-highlight | aha > diff.html

This results in the end of line 1 (and line 2) being a weird background color. I expect a white background (no background color overridden), but it's gray instead.

It looks like the ^[27m isn't cancelling the ^[7m correctly.

diff-highlight can be found at git/contrib/diff-highlight

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#19

@theZiz
Copy link
Owner

theZiz commented Sep 29, 2016

Sorry, that I needed a whole month, but I really didn't find any time. But now it should be fixed in commit d53b5e0.

@theZiz theZiz closed this as completed Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants