Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup v1.0 compatibility #31

Closed
rkunev opened this issue Jan 8, 2019 · 1 comment
Closed

Rollup v1.0 compatibility #31

rkunev opened this issue Jan 8, 2019 · 1 comment

Comments

@rkunev
Copy link

rkunev commented Jan 8, 2019

When using rollup-plugin-serve with rollup ^1.0.0 a deprecation warning is printed:

(!) serve plugin: The ongenerate hook used by plugin serve is deprecated. The generateBundle hook should be used instead.

Looks like ongenerate can be safely replaced by generateBundle here. Perhaps it's time to release rollup-plugin-serve@1.0.0 too? This way the plugin won't break for users which don't plan to upgrade to rollup@1.
@thgh thgh closed this as completed in f23e099 Jan 11, 2019
@thgh
Copy link
Owner

thgh commented Jan 11, 2019

Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thgh @rkunev