Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore regex for cljs files on the classpath #23

Closed
martintrojer opened this issue Jul 8, 2015 · 5 comments
Closed

Add ignore regex for cljs files on the classpath #23

martintrojer opened this issue Jul 8, 2015 · 5 comments

Comments

@martintrojer
Copy link

If you use libraries which bundles cljs they are included in shadow-build's cljs and make everything break horribly.

I'd like to add a regex, which is used to filter out cljs from libraries I depend on.

@thheller
Copy link
Owner

thheller commented Jul 8, 2015

Do you have an example which library does this? We had this issue before (#13, magnars/prone#21) but unfortunately some libraries seem to ship javascript they should not ship.

Do the problematic libraries include .cljs files or only the compiled .js?

@martintrojer
Copy link
Author

Its indeed prone

@thheller
Copy link
Owner

thheller commented Jul 8, 2015

Just pushed a fix, will test and push a release later. If you want to give it a shot clone master and try it like

(-> (cljs/init-state)
    (update-in [:ignore-patterns] conj #"^prone/generated/")
    ...)

(must be used before find-resources-...).

@thheller
Copy link
Owner

thheller commented Jul 9, 2015

Just release alpha13.

See the example above. You'll also need to delete the jar manifest directory (defaults to "target/shadow-build/jar-manifest") since jars are usually only processed once to speed things up a bit.

@martintrojer
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants