Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display message alerts after disconnected from watching server #189

Closed
chenyong opened this issue Feb 1, 2018 · 4 comments
Closed

display message alerts after disconnected from watching server #189

chenyong opened this issue Feb 1, 2018 · 4 comments

Comments

@chenyong
Copy link

chenyong commented Feb 1, 2018

There are some occasions I need to restart watching servers: add dependencies, upgraded shadow-cljs for new , another watching server needs my port to serve HTMLs and debugger, got strange logs I want to try restarting...

As I kill the watching server, on client, only thing happens is printing a log. The issue is the page is still there, as I go back, I don't realize it's disconnected every time. Sometimes it's showing the page from a different project.

I suggest adding an alert or a button at the bottom of the page showing that connection is broken and I need to click to reload the page.

@chenyong chenyong changed the title display message alerts after watching server disconnected display message alerts after disconnected from watching server Feb 5, 2018
@tiye
Copy link
Collaborator

tiye commented Mar 27, 2018

How about clicking to reload page?

@tiye
Copy link
Collaborator

tiye commented Mar 27, 2018

I prefer a modern look with large paddings and squared corners:

image

@thheller
Copy link
Owner

I think you can manage to click the browser reload button. Making it clickable would required some extra visual hints/text. I'm not a designer and this is very subjective. It looks the way it looks because the reload stuff started with rounded corners.

Please lets not start debating over pixels.

@tiye
Copy link
Collaborator

tiye commented Mar 28, 2018

Agreed it's subjective. To it has quite some influences on visual design. Seeing the question on the other side, can I have a on-disconnect function and let me draw UI by myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants