Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:web-worker live-reload interaction tuning #391

Closed
thheller opened this issue Sep 29, 2018 · 4 comments
Closed

:web-worker live-reload interaction tuning #391

thheller opened this issue Sep 29, 2018 · 4 comments

Comments

@thheller
Copy link
Owner

Currently no live-reload is done in web-workers and I recommend killing web-workers and restarting them in :dev/after-load. The problem is that the "main" thread decides to skip reloading code (and thus calling lifecycle fns) when only changing worker related code since the "main" won't have the code loaded. So you can't actually do what I suggest reliably and it only works if some code of the "main" thread accidentally also gets reloaded.

Should either just implement live-reload in the worker itself or find a more reliable way to restart them

@thheller
Copy link
Owner Author

This has been implemented for a while now. Forgot there was an issue about it.

@david-davidson
Copy link

Hi @thheller, I'm trying to implement this same thing! Can't seem to track down the issue you found—do you mind linking to it?

Thank you!

@thheller
Copy link
Owner Author

Not sure what you mean. I was referring to this issue not being closed when I fixed the problem.

@david-davidson
Copy link

@thheller Oh, misread your comment, I get it now. Thanks!
(And thanks for shadow-cljs in general, too!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants