feat(hdom-components): enable TS strict compiler flags (refactor)

thi-ng · Jun 4, 2019 · 6233ba2 · 6233ba2
1 parent 3143141
commit 6233ba2
Show file tree

Hide file tree

Showing 10 changed files with 33 additions and 11 deletions.
diff --git a/packages/hdom-components/adr/index.md b/packages/hdom-components/adr/index.md
@@ -0,0 +1,5 @@
+# Architecture Decision Records
+
+* [1. Record architecture decisions](0001-record-architecture-decisions.md)
+* [2. Component configuration](0002-component-configuration.md)
+* [3. Component configuration via context](0003-component-configuration-via-context.md)
diff --git a/packages/hdom-components/src/button-group.ts b/packages/hdom-components/src/button-group.ts
@@ -53,7 +53,7 @@ export interface ButtonGroupItem extends Array<any> {
 }
 
 export type ButtonGroup = (
-    _,
+    _: any,
     args: ButtonGroupArgs,
     ...buttons: ButtonGroupItem[]
 ) => any;

diff --git a/packages/hdom-components/src/button.ts b/packages/hdom-components/src/button.ts
@@ -78,7 +78,7 @@ export const button = (opts?: Partial<ButtonOpts>): Button => {
                   {
                       ...mergeAttribs(opts.attribs, args.attribs),
                       onclick: opts.preventDefault
-                          ? (e) => (e.preventDefault(), args.onclick(e))
+                          ? (e: Event) => (e.preventDefault(), args.onclick(e))
                           : args.onclick
                   },
                   ...body

diff --git a/packages/hdom-components/src/canvas.ts b/packages/hdom-components/src/canvas.ts
@@ -47,8 +47,16 @@ export interface CanvasHandlers<T extends CanvasContext> {
  * @param handlers user handlers
  * @param opts canvas context creation options
  */
-const _canvas = (type, handlers: Partial<CanvasHandlers<any>>, opts) => {
-    let el, ctx;
+const _canvas = (
+    type: string,
+    handlers: Partial<CanvasHandlers<any>>,
+    opts: Canvas2DContextAttributes | WebGLContextAttributes
+) => {
+    let el: HTMLCanvasElement;
+    let ctx:
+        | CanvasRenderingContext2D
+        | WebGLRenderingContext
+        | WebGL2RenderingContext;
     let frame = 0;
     let time = 0;
     return {

diff --git a/packages/hdom-components/src/fps-counter.ts b/packages/hdom-components/src/fps-counter.ts
@@ -39,7 +39,7 @@ export const fpsCounter = (opts?: Partial<FpsCounterOpts>) => {
         sparkline: {},
         ...opts
     };
-    return {
+    return <any>{
         init() {
             this.last = Date.now();
             this.lastLabel = this.last;

diff --git a/packages/hdom-components/src/link.ts b/packages/hdom-components/src/link.ts
@@ -6,11 +6,16 @@ export const link = (attribs: any, body: any) => [
     body
 ];
 
-export const appLink = (_, attribs: any, onclick: EventListener, body: any) => [
+export const appLink = (
+    _: any,
+    attribs: any,
+    onclick: EventListener,
+    body: any
+) => [
     "a",
     {
         href: "#",
-        onclick: (e) => {
+        onclick: (e: Event) => {
             e.preventDefault();
             onclick(e);
         },

diff --git a/packages/hdom-components/src/notification.ts b/packages/hdom-components/src/notification.ts
@@ -56,7 +56,7 @@ export interface NotificationArgs {
  * @param opts
  */
 export const notification = (opts?: Partial<NotificationOpts>) => {
-    return (_, args: Partial<NotificationArgs>, body: any) => [
+    return (_: any, args: Partial<NotificationArgs>, body: any) => [
         "div",
         { ...opts.attribs, ...args.attribs },
         opts.icon,

diff --git a/packages/hdom-components/src/pager.ts b/packages/hdom-components/src/pager.ts
@@ -137,7 +137,7 @@ export const pager = (opts: PagerOpts) => {
         },
         opts
     );
-    return (_, id: number, num: number, pageLen = 10, maxBts = 5) => {
+    return (_: any, id: number, num: number, pageLen = 10, maxBts = 5) => {
         const bt = opts.button;
         const step = opts.navStep;
         const maxID = Math.floor(Math.max(0, num - 1) / pageLen);

diff --git a/packages/hdom-components/src/sparkline.ts b/packages/hdom-components/src/sparkline.ts
@@ -41,7 +41,11 @@ export interface SparklineOpts {
  * @param opts config options
  * @param vals data values
  */
-export const sparkline = (_, opts: Partial<SparklineOpts>, vals: number[]) => {
+export const sparkline = (
+    _: any,
+    opts: Partial<SparklineOpts>,
+    vals: number[]
+) => {
     opts = {
         min: 0,
         max: 100,

diff --git a/packages/hdom-components/src/title.ts b/packages/hdom-components/src/title.ts
@@ -42,7 +42,7 @@ export const title = (opts?: Partial<TitleOpts>) => {
         },
         opts
     );
-    return (_, title, subtitle) => [
+    return (_: any, title: any, subtitle: any) => [
         opts.element,
         opts.attribs,
         title,