refactor(geom): update Path & PathBuilder.close()

BREAKING CHANGE: rename `PathBuilder.closePath()` => `PathBuilder.close()` - update `Path.close()` to return path itself
thi-ng · May 7, 2024 · b2134c2 · b2134c2
1 parent 88b2c40
commit b2134c2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/geom/src/api/path.ts b/packages/geom/src/api/path.ts
@@ -39,6 +39,7 @@ export class Path implements IClear, IHiccupShape {
 
 	close() {
 		if (!this.closed) this.segments.push(CLOSE);
+		return this;
 	}
 
 	copy(): Path {

diff --git a/packages/geom/src/path-builder.ts b/packages/geom/src/path-builder.ts
@@ -147,7 +147,7 @@ export class PathBuilder {
 		return this;
 	}
 
-	closePath() {
+	close() {
 		this.curr.addSegments({
 			geo: new Line([copy(this.currP), copy(this.startP)]),
 			type: "l",

diff --git a/packages/geom/src/path-from-svg.ts b/packages/geom/src/path-from-svg.ts
@@ -67,7 +67,7 @@ export const pathFromSvg = (svg: string) => {
 					break;
 				}
 				case "z":
-					b.closePath();
+					b.close();
 					break;
 				default:
 					throw new Error(