Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to TF2. #13

Open
tatsubori opened this issue Nov 6, 2020 · 2 comments
Open

Migration to TF2. #13

tatsubori opened this issue Nov 6, 2020 · 2 comments

Comments

@tatsubori
Copy link

In my fork, I have successfully adjusted both rddl2tf and rddgym for TensorFlow 2, which is more easily available and maintained these days. Unfortunate is that we don't have a backward compatibility to TF1.

What would be the best offering we can make?
a) merge into the master, increasing a major/minor version.
b) proving a separate fork with a different name, say, rddl2tf_tf2 and rddlgym_tf2.
c) just leave it in a branch.

What do you say?

@thiagopbueno
Copy link
Owner

Hi @tatsubori

Thanks for your interest in rddl2tf and rddlgym. I really appreciate your effort to migrate my packages to TF2. I've been wondering about doing that for some time now.

Since I have a number of public and private projects that strongly depend on both packages I believe the best option right now would be to open a PR for us to review the code (and make sure all the tests pass), and then merge your commits into a temporary rddl2tf_tf2 branch. This will allow me to take the time to figure out how this change will impact my current work. After that, I will be glad to release a new rddl2tf version acknowledging your contribution.

Does that seem good to you?

Cheers,
Thiago

@tatsubori
Copy link
Author

tatsubori commented Nov 7, 2020

Sure. Just created PRs for both rddl2tf and rddlgym for your review. Let me know if you want PRs to new branches instead. I will follow your instruction as you want. :->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants