You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my fork, I have successfully adjusted both rddl2tf and rddgym for TensorFlow 2, which is more easily available and maintained these days. Unfortunate is that we don't have a backward compatibility to TF1.
What would be the best offering we can make?
a) merge into the master, increasing a major/minor version.
b) proving a separate fork with a different name, say, rddl2tf_tf2 and rddlgym_tf2.
c) just leave it in a branch.
What do you say?
The text was updated successfully, but these errors were encountered:
Thanks for your interest in rddl2tf and rddlgym. I really appreciate your effort to migrate my packages to TF2. I've been wondering about doing that for some time now.
Since I have a number of public and private projects that strongly depend on both packages I believe the best option right now would be to open a PR for us to review the code (and make sure all the tests pass), and then merge your commits into a temporary rddl2tf_tf2 branch. This will allow me to take the time to figure out how this change will impact my current work. After that, I will be glad to release a new rddl2tf version acknowledging your contribution.
Sure. Just created PRs for both rddl2tf and rddlgym for your review. Let me know if you want PRs to new branches instead. I will follow your instruction as you want. :->
In my fork, I have successfully adjusted both rddl2tf and rddgym for TensorFlow 2, which is more easily available and maintained these days. Unfortunate is that we don't have a backward compatibility to TF1.
What would be the best offering we can make?
a) merge into the master, increasing a major/minor version.
b) proving a separate fork with a different name, say, rddl2tf_tf2 and rddlgym_tf2.
c) just leave it in a branch.
What do you say?
The text was updated successfully, but these errors were encountered: