We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, Thanks for the excellent work. I found a "retain cycle". IDMZoomingScrollView -> IDMPhoto -> IDMProgressUpdateBlock -> IDMZoomingScrollView
- (void)configurePage:(IDMZoomingScrollView *)page forIndex:(NSUInteger)index { page.frame = [self frameForPageAtIndex:index]; page.tag = PAGE_INDEX_TAG_OFFSET + index; page.photo = [self photoAtIndex:index]; __block __weak IDMPhoto *photo = (IDMPhoto*)page.photo; photo.progressUpdateBlock = ^(CGFloat progress){ [page setProgress:progress forPhoto:photo]; }; }
Should use a '__weak' ref for page involved in the block above, or break the cycle in method unloadUnderlyingImage.
unloadUnderlyingImage
The text was updated successfully, but these errors were encountered:
Fixed! It will be in the next version. Thanks!
Sorry, something went wrong.
No branches or pull requests
Hi,
Thanks for the excellent work.
I found a "retain cycle".
IDMZoomingScrollView -> IDMPhoto -> IDMProgressUpdateBlock -> IDMZoomingScrollView
Should use a '__weak' ref for page involved in the block above, or break the cycle in method
unloadUnderlyingImage
.The text was updated successfully, but these errors were encountered: