Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DraftJS ^0.11.0 as a peer dependency #77

Closed
erikt9 opened this issue Oct 10, 2019 · 2 comments · Fixed by #78
Closed

Allow DraftJS ^0.11.0 as a peer dependency #77

erikt9 opened this issue Oct 10, 2019 · 2 comments · Fixed by #78
Labels
enhancement New feature or request released

Comments

@erikt9
Copy link
Contributor

erikt9 commented Oct 10, 2019

I haven't experienced any problems using drafts-filters with the 0.11 draftjs series. However, npm will complain about missing peer dependencies if I'm including this current version of draftjs since this project's package.json has "draft-js": "^0.10.4" as a peer dependency.

@erikt9 erikt9 added the enhancement New feature or request label Oct 10, 2019
@thibaudcolas
Copy link
Owner

Hey @erikt9, thanks for the report. I haven’t had time to test this myself but I’ve reviewed the CHANGELOG for 0.11 and I don’t think I had particular concerns with it – so if you’re ok to make a PR I’m happy to merge it, if all of the project’s unit tests pass with Draft.js 0.11.

This is what I’d expect the new target to be:

  "peerDependencies": {
    "draft-js": "^0.10.4 || ^0.11.0"
  },

If you’re interested in contributing further, I’d like to also have Travis CI run tests for both Draft.js 0.10 and 0.11 with a test matrix – but that’s a bit more work so this can wait.

@thibaudcolas
Copy link
Owner

🎉 This issue is fixed in v2.2.4, available on npm: draftjs-filters@2.2.4.

Generated by 📦🚀 semantic-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants