Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme not rendering on jsonresume.org #4

Closed
benthemonkey opened this issue Jan 7, 2016 · 5 comments
Closed

Theme not rendering on jsonresume.org #4

benthemonkey opened this issue Jan 7, 2016 · 5 comments

Comments

@benthemonkey
Copy link

Have a look at http://themes.jsonresume.org/eloquent (which you link to in your readme) and http://registry.jsonresume.org/#eloquent

@benthemonkey
Copy link
Author

Here's what the page displays: https://gist.github.com/benthemonkey/6a3656553e044e86391c

@thibaudcolas
Copy link
Owner

Hey @benthemonkey, thanks for the report.

Unfortunately I don't think I can do much about this, it seems to be a registry error. I've had issues with it before so I think it might be time for me to stop relying on this for the demo. I changed my demo link to point to a file in the repo (https://rawgit.com/ThibWeb/jsonresume-theme-eloquent/master/test/resume.html), and created an issue on the theme-manager project: jsonresume/theme-manager#27.

I think I might distance this project even further apart from jsonresume.org by having a separate online renderer to edit the resume content or a separate command line tool (like jsonresume-theme-eloquent resume.json) to render the theme. Future stuff to consider.


Some debug info for reference.

The registry is able to render the theme at any version. I can see that http://themes.jsonresume.org/eloquent@2.2.0 fails with what you reported above, http://themes.jsonresume.org/eloquent@2.1.0 fails with another error and http://themes.jsonresume.org/eloquent@1.2.0 works as expected. It doesn't help much though because nothing has changed with how I require Handlebars between those versions.

  • On my local machine the latest version of the theme works as expected on Node 0.10 / 0.12 / 4 / 5.
  • I just released a new version to force the registry to rebuild the theme.

@thibaudcolas
Copy link
Owner

This seems to be solved in 2.2.3 but I have no idea why. There's now a new error that also seems to be registry-related, will look into it.

@thibaudcolas
Copy link
Owner

For reference this is now fixed on all registry endpoints (http://themes.jsonresume.org/eloquent). I have no idea why. My changes didn't really relate to the errors that were displayed.

¯\_(ツ)_/¯

@benthemonkey
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants