Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sources in the Maven Central #46

Closed
jksiezni opened this issue Sep 15, 2022 · 3 comments
Closed

Missing sources in the Maven Central #46

jksiezni opened this issue Sep 15, 2022 · 3 comments

Comments

@jksiezni
Copy link

The Maven Central does not provide sources artifact for the StreamPack. Could you add sources to published artifacts?

I try to implement my own ISurfaceCapture for live streaming GL-rendered content, however it is very difficult to understand hierarchy and what library classes do without sources. The Android Studio has a "Download sources" feature, but it doesn't work for your library due to missing sources artifact.

There is a stackoverflow answer that presents a simple solution to this issue: https://stackoverflow.com/questions/26874498/publish-an-android-library-to-maven-with-aar-and-sources-jar I can use it to publish sources in a local maven, but I thought it's worth sharing to help other devs too.

@ThibaultBee
Copy link
Owner

Hi,
That's a great idea :)
I will add this on my TODO list.
Glad to hear someone is working on custom interfaces. This is exactly the purpose of this library. If you want to add your ISurfaceCapture in the project, I can review/accept your merge request.

BTW, if you are looking to implement your own interfaces, there are info in the DEVELOPER_README.md

Best regards,
Thibault

@ThibaultBee
Copy link
Owner

Add in 9366c21
Will be in next release.

@ThibaultBee
Copy link
Owner

Done in 2.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants